Skip to content

Commit

Permalink
Swagger updates to address docs and sdk issues (#2139)
Browse files Browse the repository at this point in the history
* added extension properties to Get & GetNode

* fix indentation

* fix indentation

* changed description text

* Adding new API version (2017-05-15-preview). No other changes made (#2)

Adding new API version (2017-05-15-preview). Only three new resources added and all others reference the previous version. 

- Added resources:
 - SoftwareUpdateConfiguration
 - SoftwareUpdateConfigurationRun
 - SoftwareUpdateConfigurationMachineRun

- Validations:
 - Autorest azure validations passed
  - x-ms-examples validated with no errors

* Updated tag in global configuration

Updated tag in global configuration to use the latest api version as per azure PR review comment

* - Fixed 2 typos in URLs (#4)

- Moved parameters inside operations as it was not showing properly in documentation.

* Fixing merge error

Fixing merge error

* Fixing merge error

Fixing merge error

* swagger updates to address docs and sdk issues (#5)

* Changed property type to integer

* includedUpdateClassifications to scalar integer

* model as string

* type to string

* Created adhoc property to allow code generation of enum with bitfield values since it seems that autorest doesn't support birfields and generate the enum only for string type property

* test

* Removed readonly attribute from name to allow setting outside constructor

* Fixed parameter type and replaced reference to parameter with actual definition

* removed descriminator property

* trying modelAsString with false

* modeled includedUpdateClassifications as string as deserialization was failing

* - First letter capital for better looking doc
- Replaces referece to paramaters with actual definitions on all resources
- Cleaned common definition file

* fixed x-ms-enum without enum on same level error in code generation

* removed subid/rg/aa parameters to simplify sdk

* added paemeters tat path level to avoid passing as arguments in sdk

* more fixes

* more fixes

* fixing more parameters

* Added missing automationAccountName parameter

* made resourceGroupName passed in function for account resource

* made schedule info requred property

* moved filter parameter for better sdk parameter ordering

* ran auto indent on files

* Reformatted the file to use two-spaced indentation as per recommendation.

* Fixing API version in definitions.json
  • Loading branch information
finiteattractor authored and marstr committed Dec 19, 2017
1 parent 1f90a24 commit ca571e3
Show file tree
Hide file tree
Showing 6 changed files with 959 additions and 937 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@
},
"parameters": [
{
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"pattern": "^[-\\w\\._]+$",
"description": "The resource group name."
},
{
"name": "automationAccountName",
Expand Down Expand Up @@ -88,7 +93,12 @@
},
"parameters": [
{
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"pattern": "^[-\\w\\._]+$",
"description": "The resource group name."
},
{
"name": "automationAccountName",
Expand Down Expand Up @@ -150,7 +160,12 @@
},
"parameters": [
{
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"pattern": "^[-\\w\\._]+$",
"description": "The resource group name."
},
{
"name": "automationAccountName",
Expand Down Expand Up @@ -197,7 +212,12 @@
},
"parameters": [
{
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"pattern": "^[-\\w\\._]+$",
"description": "The resource group name."
},
{
"name": "automationAccountName",
Expand Down Expand Up @@ -246,7 +266,12 @@
},
"parameters": [
{
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"pattern": "^[-\\w\\._]+$",
"description": "The resource group name."
},
{
"$ref": "./definitions.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -362,7 +387,12 @@
},
"parameters": [
{
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"pattern": "^[-\\w\\._]+$",
"description": "The resource group name."
},
{
"name": "automationAccountName",
Expand Down Expand Up @@ -421,7 +451,12 @@
},
"parameters": [
{
"$ref": "./definitions.json#/parameters/ResourceGroupNameParameter"
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"pattern": "^[-\\w\\._]+$",
"description": "The resource group name."
},
{
"name": "automationAccountName",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3755,8 +3755,7 @@
"required": true,
"type": "string",
"pattern": "^[-\\w\\._]+$",
"description": "The resource group name.",
"x-ms-parameter-location": "method"
"description": "The resource group name."
}
}
}
Loading

0 comments on commit ca571e3

Please sign in to comment.