Skip to content

Commit

Permalink
Reduced warnings count (#6043)
Browse files Browse the repository at this point in the history
* Suppress "expected" warnings

* Refactored ApiVersion, SubscriptionId params usage

* Fixed VMSS related warnings
  • Loading branch information
EvgenyAgafonchikov authored and dsgouda committed May 22, 2019
1 parent ed71a2b commit b03ac09
Show file tree
Hide file tree
Showing 7 changed files with 76 additions and 156 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
"description":"Gets all the Azure Firewall FQDN Tags in a subscription.",
"parameters":[
{
"$ref":"#/parameters/ApiVersionParameter"
"$ref": "./network.json#/parameters/ApiVersionParameter"
},
{
"$ref":"#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
}
],
"responses":{
Expand Down Expand Up @@ -120,21 +120,5 @@
},
"description":"Response for ListAzureFirewallFqdnTags API service call."
}
},
"parameters": {
"SubscriptionIdParameter": {
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string",
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
},
"ApiVersionParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "Client API version."
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,20 @@
"required": true,
"type": "string",
"description": "Client API version."
},
"ApiVersionVmssParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@
}
}
}
},
"definitions": {
},
"definitions": {
"VirtualNetworkTap": {
"properties": {
"properties": {
Expand Down Expand Up @@ -374,21 +374,5 @@
},
"description": "Response for ListVirtualNetworkTap API service call."
}
},
"parameters": {
"SubscriptionIdParameter": {
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string",
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
},
"ApiVersionParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "Client API version."
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,7 @@
"description": "The virtual machine index."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -120,18 +109,7 @@
"description": "The name of the virtual machine scale set."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -190,18 +168,7 @@
"description": "The name of the network interface."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -264,18 +231,7 @@
"description": "The name of the network interface."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -348,18 +304,7 @@
"description": "The name of the ip configuration."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,7 @@
"description": "The name of the virtual machine scale set."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -128,18 +117,7 @@
"description": "The IP configuration name."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -209,18 +187,7 @@
"description": "The name of the public IP Address."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@
"description": "The name of the resource group."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "./network.json#/parameters/ApiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -136,10 +136,10 @@
"description": "The name of the policy."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "./network.json#/parameters/ApiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -179,7 +179,7 @@
"description": "The name of the policy."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"description": "Policy to be created.",
Expand Down Expand Up @@ -237,10 +237,10 @@
"description": "The name of the policy."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "./network.json#/parameters/ApiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -533,21 +533,5 @@
}
}
}
},
"parameters": {
"SubscriptionIdParameter": {
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string",
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
},
"ApiVersionParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "Client API version."
}
}
}
42 changes: 42 additions & 0 deletions specification/network/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,48 @@ directive:
- suppress: RequiredPropertiesMissingInResourceModel
from: webapplicationfirewall.json
reason: name, id and type properties are inherited from the upper level
- suppress: PostOperationIdContainsUrlVerb
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/getBackendHealthOnDemand"].post.operationId
reason: Customized verb is used for API
- suppress: PostOperationIdContainsUrlVerb
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/vpnConfiguration"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/backendhealth"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkInterfaces/{networkInterfaceName}/effectiveRouteTable"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/securityGroupView"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/connectionMonitors/{connectionMonitorName}/query"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/networkConfigurationDiagnostic"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{virtualNetworkName}/CheckIPAddressAvailability"].get.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getBgpPeerStatus"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getLearnedRoutes"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getAdvertisedRoutes"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getVpnClientConnectionHealth"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/supportedSecurityProviders"].get.operationId
reason: Customized verb is used for API
- suppress: GetInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/supportedSecurityProviders"].get.operationId
reason: Customized verb is used for API
```

---
Expand Down

0 comments on commit b03ac09

Please sign in to comment.