Skip to content

Commit

Permalink
Azure Relay - added missing publicNetworkAccess at NetwrokRuleSet lev…
Browse files Browse the repository at this point in the history
…el (#20745)

* Update NetworkRuleSets.json Revised

Customer wanted to disable publicNetworkAccess via ARM template. Doc is not updated. I have tested it locally and found that publicNetworkAccess property should be part of NetworkRuleSet
{

      "type": "Microsoft.Relay/namespaces/networkRuleSets",

      "apiVersion": "2021-11-01",

      "name": "samplehyb1232434/default",

      "location": "East US",

      "dependsOn": [

        "[resourceId('Microsoft.Relay/namespaces', 'samplehyb1232434')]"

      ],

      "properties": {

        "defaultAction": "Allow",

        "ipRules": [

          {}

        ],

       "publicNetworkAccess": "Disabled"

      }

    }

* fixed lint and prettier

* updated readme for typescript

* updated description

Co-authored-by: Ajit Maruti Navasare (MINDTREE LIMITED) <v-ajnav@microsoft.com>
  • Loading branch information
SudeshnaB1902 and Ajit Maruti Navasare (MINDTREE LIMITED) committed Nov 3, 2022
1 parent 3874928 commit 591b17c
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,19 @@
"modelAsString": true
}
},
"publicNetworkAccess": {
"type": "string",
"description": "This determines if traffic is allowed over public network. By default it is enabled",
"enum": [
"Disabled",
"Enabled",
"SecuredByPerimeter"
],
"x-ms-enum": {
"name": "PublicNetworkAccess",
"modelAsString": true
}
},
"ipRules": {
"type": "array",
"items": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"description": "Result of the request to list Relay operations. It contains a list of operations and a URL link to get the next set of results.",
"properties": {
"value": {
"description": "List of Relay operations supported by the Microsoft.EventHub resource provider.",
"description": "List of Relay operations supported by the Microsoft.Relay resource provider.",
"type": "array",
"readOnly": true,
"items": {
Expand Down
8 changes: 4 additions & 4 deletions specification/relay/resource-manager/readme.typescript.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Please also specify `--typescript-sdks-folder=<path to root folder of your azure
``` yaml $(typescript) && !$(profile-content)
typescript:
azure-arm: true
package-name: "@azure/arm-eventhub"
output-folder: "$(typescript-sdks-folder)/sdk/eventhub/arm-eventhub"
package-name: "@azure/arm-relay"
output-folder: "$(typescript-sdks-folder)/sdk/relay/arm-relay"
generate-metadata: true
```
Expand All @@ -17,8 +17,8 @@ These settings apply only when `--profile-content=profile-hybrid-2020-09-01` is

``` yaml $(profile-content)=='profile-hybrid-2020-09-01'
typescript:
package-name: "@azure/arm-eventhub-profile-2020-09-01-hybrid"
output-folder: "$(typescript-sdks-folder)/sdk/eventhub/arm-eventhub-profile-2020-09-01-hybrid"
package-name: "@azure/arm-relay-profile-2020-09-01-hybrid"
output-folder: "$(typescript-sdks-folder)/sdk/relay/arm-relay-profile-2020-09-01-hybrid"
azure-arm: true
generate-metadata: true
batch:
Expand Down

0 comments on commit 591b17c

Please sign in to comment.