-
Notifications
You must be signed in to change notification settings - Fork 16.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bicep - function-app-windows-consumption #13797
base: master
Are you sure you want to change the base?
Conversation
@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
@ggailey777 - can you take a look of this PR. The package, https://zipfortesting.blob.core.windows.net/deployment/cp-lin-py.zip, doesn't exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to remove the ARM template?
@@ -19,6 +20,8 @@ languages: | |||
![Best Practice Check](https://azurequickstartsservice.blob.core.windows.net/badges/quickstarts/microsoft.web/function-app-windows-consumption/BestPracticeResult.svg) | |||
![Cred Scan Check](https://azurequickstartsservice.blob.core.windows.net/badges/quickstarts/microsoft.web/function-app-windows-consumption/CredScanResult.svg) | |||
|
|||
![Bicep Version](https://azurequickstartsservice.blob.core.windows.net/badges/quickstarts/microsoft.web/function-app-windows-consumption/BicepVersion.svg) | |||
|
|||
This sample Azure Resource Manager template deploys an Azure Function App on Windows Consumption plan and required resource including ZipDeploy extension to mount zip package for deployment. | |||
|
|||
[![Deploy To Azure](https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/1-CONTRIBUTION-GUIDE/images/deploytoazure.svg?sanitize=true)](https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fazure-quickstart-templates%2Fmaster%2Fquickstarts%2Fmicrosoft.web%2Ffunction-app-windows-consumption%2Fazuredeploy.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you just delete this file?
@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
…mplates into 0222-function-app-windows-consumption
@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
@ggailey777 - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
@ggailey777 - do you know anything about the following error message: 2:26:59 PM - The deployment 'mainTemplate-deployment' failed with error(s). Showing 1 out of 1 error(s). at Microsoft.Web.Deployment.NativeMethods.RaiseIOExceptionFromErrorCode(Win32ErrorCode errorCode, String maybeFullPath) |
@mumian the command you issued was incorrect. Please try again. Examples are:
and
|
@ggailey777 - can you provide some details? My knowledge of azure functions is quite limited. |
@description('The sasToken required to access _artifactsLocation. When the template is deployed using the accompanying scripts, a sasToken will be automatically generated. Use the defaultValue if the staging location is not secured.') | ||
param _artifactsLocationSasToken string = '' | ||
|
||
var packageUri = uri(_artifactsLocation, 'packages/nodejs.zip${_artifactsLocationSasToken}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patelchandni we're having trouble deploying with the package .zip file in this repo. Is this possible, or does it have to be some public URL location? I'm not familiar with how to do this in Bicep (or ARM frankly).
resource msDeploy 'Microsoft.Web/sites/extensions@2023-01-01' = { | ||
parent: functionApp | ||
name: 'MSDeploy' | ||
properties: { | ||
packageUri: packageUri | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to @patelchandni, it sounds like the bicep-first approach might not work here since Functions requires a zipdeploy
resource, which doesn't seem to yet be supported by Bicep. The PM for Functions deployments is @im-samz.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, @ggailey777. Feel free to set time up next week to discuss this in more detail. Weird that Bicep wouldn't support the zipdeploy
resource.
PR Checklist
Check these items before submitting a PR...
Contribution Guide
Best Practice Guide
Changelog