Command to Rename SQL database #5009

jaredmoo · 2017-11-18T01:40:25Z

Description

Add ability to rename SQL database.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

jaredmoo · 2017-11-18T01:44:22Z

src/ResourceManager/Sql/Commands.Sql/Database/Model/AzureSqlDatabaseModel.cs

+        /// <summary>
+        /// Template to generate database id
+        /// </summary>
+        public const string IdTemplate = "/subscriptions/{0}/resourceGroups/{1}/providers/Microsoft.Sql/servers/{2}/databases/{3}";


should be internal

maddieclayton · 2017-11-20T18:51:37Z

@jaredmoo To fix your build issues, add the breaking change error found in your build under BreakingChangeIssues.csv to this file. It looks like these are false positives. Let me know if you have any questions.

cormacpayne

@jaredmoo a few minor comments, otherwise LGTM

cormacpayne · 2017-11-21T16:49:32Z

src/ResourceManager/Sql/Commands.Sql/Commands.Sql.csproj

@@ -472,13 +471,25 @@
      <HintPath>..\..\..\packages\Microsoft.Data.Services.Client.5.8.2\lib\net40\Microsoft.Data.Services.Client.dll</HintPath>
      <Private>True</Private>
    </Reference>
+    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


@jaredmoo you can remove the references added in this file (Microsoft.Rest.ClientRuntime, Microsoft.Rest.ClientRuntime.Azure, and Newtonsoft.Json) since they are already handled in the Common.Dependencies.targets file.

cormacpayne · 2017-11-21T16:51:33Z

src/ResourceManager/Sql/Commands.Sql/help/Set-AzureRmSqlDatabase.md

@@ -165,12 +173,25 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```

+### -NewName
+The new name to rename the database to.```yaml


@jaredmoo make sure to move the ```yaml block to a line by itself like all other parameters in this file. This is a bug in the platyPS module

cormacpayne · 2017-11-21T16:52:02Z

src/ResourceManager/Sql/Commands.Sql/packages.config

  <package id="Microsoft.Azure.Management.Storage" version="2.4.0-preview" targetFramework="net45" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.10" targetFramework="net452" />


@jaredmoo same comment about removing the added references since they are taken care of in a separate common project

cormacpayne · 2017-11-21T21:08:44Z

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/188/

jaredmoo added 3 commits November 17, 2017 14:24

Added Set-AzureRmSqlDatabase -NewName param

d3bdf63

Regen help

02b95e4

Added db rename test

7a2ddbb

jaredmoo requested review from akromm-zz and cormacpayne November 18, 2017 01:40

Added changelog

afc0594

jaredmoo commented Nov 18, 2017

View reviewed changes

Made IdTemplate internal

1b5e386

azuresdkci added the needs-review label Nov 18, 2017

azuresdkci assigned markcowl Nov 18, 2017

akromm-zz previously approved these changes Nov 20, 2017

View reviewed changes

Eliminate breaking change false positives

b72edc5

jaredmoo dismissed akromm-zz’s stale review via b72edc5 November 20, 2017 19:00

Fixed BreakingChangeIssues.csv

d7b9e11

jaredmoo mentioned this pull request Nov 20, 2017

Get-AzureRMSqlDatabase how to rename a database #3571

Closed

cormacpayne suggested changes Nov 21, 2017

View reviewed changes

cormacpayne added needs-revision and removed needs-review labels Nov 21, 2017

cormacpayne assigned jaredmoo and unassigned markcowl Nov 21, 2017

jaredmoo added 2 commits November 21, 2017 09:46

Removed common dependencies

a498ef0

Fixed help file syntax

3ba2e0e

cormacpayne approved these changes Nov 21, 2017

View reviewed changes

cormacpayne added Waiting for On Demand and removed needs-revision labels Nov 21, 2017

cormacpayne unassigned jaredmoo Nov 21, 2017

cormacpayne merged commit 3d83731 into Azure:preview Nov 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Command to Rename SQL database #5009

Command to Rename SQL database #5009

jaredmoo commented Nov 18, 2017 •

edited

Loading

jaredmoo Nov 18, 2017

maddieclayton commented Nov 20, 2017 •

edited

Loading

cormacpayne left a comment

cormacpayne Nov 21, 2017

cormacpayne Nov 21, 2017

cormacpayne Nov 21, 2017

cormacpayne commented Nov 21, 2017

		<package id="Microsoft.Azure.Management.Storage" version="2.4.0-preview" targetFramework="net45" />
		<package id="Microsoft.Rest.ClientRuntime" version="2.3.10" targetFramework="net452" />

Command to Rename SQL database #5009

Command to Rename SQL database #5009

Conversation

jaredmoo commented Nov 18, 2017 • edited Loading

Description

Choose a reason for hiding this comment

maddieclayton commented Nov 20, 2017 • edited Loading

cormacpayne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cormacpayne commented Nov 21, 2017

jaredmoo commented Nov 18, 2017 •

edited

Loading

maddieclayton commented Nov 20, 2017 •

edited

Loading