Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ApiManagement] Secure Parameter for Cmdlets #4819

Closed
wants to merge 16 commits into from

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Oct 19, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

ro-joowan and others added 8 commits October 9, 2017 11:32
[ADLA]

* Changed one of the two OutputTypes of
Get-AzureRmDataLakeAnalyticsAccount
- List<DataLakeAnalyticsAccount> to
List<PSDataLakeAnalyticsAccountBasic>
- The properties of PSDataLakeAnalyticsAccountBasic is a strict subset
of the properties of DataLakeAnalyticsAccount
- The additional properties that are in DataLakeAnalyticsAccount are not
returned by the service.  Therefore, this change is to reflect this
accurately.
* Changed one of the two OutputTypes of Get-AzureRmDataLakeAnalyticsJob
- List<JobInformation> to List<PSJobInformationBasic>
- The properties of PSJobInformationBasic is a strict subset of the
properties of JobInformation
- The additional properties that are in JobInformation are not returned
by the service.  Therefore, this change is to reflect this accurately.
* Updated the cmdlet logic of Submit-AzureRmDataLakeAnalyticsJob because
SubmitJob and BuildJob now require an explicit parameter object rather
than the generic JobInformation object
* Removed the Obsolete Properties fields in
PSDataLakeAnalyticsAccount.cs and its assoicated files

[ADLS]

* Changed one of the two OutputTypes of Get-AzureRmDataLakeStoreAccount
- List<PSDataLakeStoreAccount> to List<PSDataLakeStoreAccountBasic>
- The properties of PSDataLakeStoreAccountBasic is a strict subset of
the properties of PSDataLakeStoreAccount
- The additional properties that are in PSDataLakeStoreAccount are not
returned by the service.  Therefore, this change is to reflect this
accurately.
* Removed the Obsolete Properties fields in PSDataLakeStoreAccount.cs
and its assoicated files
* Removing these from csproj files and packages.config
@solankisamir solankisamir mentioned this pull request Oct 20, 2017
13 tasks
@solankisamir solankisamir added this to the November 2017 milestone Oct 20, 2017
@solankisamir
Copy link
Member Author

This pull request got commits from some other branch. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants