-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverting change that resulted in issue #4323 #4371
Conversation
@ro-joowan, |
Can one of the admins verify this patch? |
@azuresdkci add to whitelist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ro-joowan @begoldsm any tests to avoid future regressions?
Hi Cormac (@cormacpayne), Talked with Ben yesterday about adding tests to avoid future regressions. We decided not to add any tests at the moment because of the difficulty in creating a user-managed KeyVault account. If we run into issues in the future, I'll be more than happy to look into it further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ro-joowan we can work with you next release on creating the tests necessary to test this functionality. For now, let's open an issue to track the status of creating that test(s) and add the Test Debt
label to it.
Sounds good, thanks! |
Description
Issue: #4323
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines