Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of New-AzureRmDisk, New-AzureRmSnapshot, Update-AzureRm… #4314

Merged
merged 1 commit into from
Jul 14, 2017

Conversation

hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Jul 13, 2017

…Disk and Update-AzureRmSnapshot.

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@NeilBird
Copy link

I have experienced issues with the New-AzureRmSnapshot cmd-let, giving the following error:

New-AzureRmSnapshot : The request content was invalid and could not be deserialized: 'Could not find member 'AccountType' on object of type 'ResourceDefinition'. Path 'AccountType', line 2, position 17.'.
ErrorCode: InvalidRequestContent

ErrorMessage: The request content was invalid and could not be deserialized: 'Could not find member 'AccountType' on object of type 'ResourceDefinition'. Path 'AccountType', line 2, position 17.'.
StatusCode: 400
ReasonPhrase: Bad Request
OperationID : f4c63d19-bd1c-4d5a-a9ae-03df6b1358ac

Will this commit resolve this issue? Or should I submit an new issue. Happy to provide more details / context if required.
Regards
Neil

@hyonholee
Copy link
Contributor Author

@NeilBird This RP will resolve the issue.

@markcowl markcowl changed the base branch from release-4.2.0 to release-4.2.1 July 13, 2017 22:07
@markcowl
Copy link
Member

@markcowl markcowl merged commit ef766b9 into Azure:release-4.2.1 Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants