Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not Squash] Merge main branch to Az.Storage-preview branch #20973

Merged
merged 38 commits into from
Feb 21, 2023

Conversation

blueww
Copy link
Member

@blueww blueww commented Feb 20, 2023

Description

File a new PR since #20956 can't pass PR check.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

greathongtu and others added 30 commits February 10, 2023 10:05
Co-authored-by: Hongtu Zhang (FA Talent) <v-hongtzhang@microsoft.com>
* [DataFactory]Updated ADF .Net SDK version to 9.1.0

* update
* Nuget Update with Auto Rest

* CS files updates

* sln update
* Set up first CI try with Azure Pipelines

description here! [skip ci]

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* commit me

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* remove test yml

* rectify_git_url

---------

Co-authored-by: Hongtu Zhang (FA Talent) <v-hongtzhang@microsoft.com>
…tation to Azure Database Migration Service (classic) (#20893)

* Rename Azure Database migration Service to Azure Database Migration Service (classic)

* fix PR comments
`-Confirm` in the examples were not in the correct format to override the confirmation prompt
* Fix the issue that CI doesn't check online version of help doc

* Fix the online version in help docs

* Fix the online version in help docs

* Fix the example issue

* Fix the example issue
* Added Snat parameter to firewall policy cmdlets

* Generated help for new cmdlet and updated for the existing ones

* fixed pipeline analyze issue

* Removed SupportsShouldProcess

* suppressed static analyzer

* Updated help per PR review comments

---------

Co-authored-by: Gizachew Eshetie <v-geshetie@microsoft.com>
* Fix/connectedk8s ps5 (#20603)

* Create RSAHelper.ps1

* Update New-AzConnectedKubernetes.ps1

* Add try-catch and update function parameters

* Update New-AzConnectedKubernetes.ps1

* [Az.ConnectedKubernetes] Update ChangeLog  (#20649)

* Update RSAHelper.ps1 (coding style)

* Update ChangeLog.md

* upgrade Az.ConnectedKubernetes from 0.7.0 to 0.7.1

---------

Co-authored-by: Ann Lu <112682982+yinghsugn@users.noreply.github.com>
Skip PR creatation if there is not change in fabricbot.json
…20917)

* spark pool isolate compute/nodesize related changes

* update change log

* updateazsynapselinkconnectionlandingzonecredential
* Add missing online version

* Add missing online version

* Add missing online version

* Fix the broken help files

* Supress the example exceptions

* Remove the supression the example exceptions
…WafPolicy (#20908)

* {AzureFrontDoor} fixes #20870 Adding Tag parameter to New-AzFrontDoorWafPolicy

fixes #20870 

Adding Tag parameter to New-AzFrontDoorWafPolicy

This PR Allow the passing of tags when creating a new Azure Front Door Waf Policy resource. 
Currently, tags can be added in the portal but not via powershell for the FrontDoor WAF policy.

* Update ChangeLog.md

* Update src/FrontDoor/FrontDoor/ChangeLog.md

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* Update src/FrontDoor/FrontDoor/Cmdlets/NewFrontDoorWafPolicy.cs

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>

* Update NewFrontDoorWafPolicy.cs

* Updating the help docs New-AzFrontDoorWafPolicy.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
* Move ServiceBus to main

* Update ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
* add pipeline yml for syncing fabricbot.json aliases

* change git user name and email in script

* change inline script to GetWiki2Json.ps1 file

* remove unnecessary code

* change wrong dir

* change to my personal repo for test

* change the usage of token

* change CreatePR.ps1 for test

* correct ParseWiki2Json.ps1

* remove unnecessary output

* remove quote

* finish test, change back to Azure repo

* change branch name

* change some names

* remove the use of magic number

* change commit message

* remove redundant git pull

* change the way of getting wiki content

* change space to -

* add md

* set current dir

* use space

* use -

* still use ADOToken

* use a better wiki url

* test purpose

* test2

* test oauth

* test3

* finish test

* test again

* test

* finish  test

* test cron

* test double pr

* solve double pr

* test

* test

* test

* finish test

* test

* finish test

* test restapi

* te

* finish test

* test

* finish test

* filter pr

* test

* test

* test

* test

* finish test

* Solve pipeline error when no changes

* add newline at end of file

* change to pwsh

* test diff

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* testt

* testt

* testt

* testt

* Update sync-aliases.yml for Azure Pipelines

* testt

* testt

* test yml condition synthx

* add succeed

* add trim

* add null check

* add newline

* remove checkout

* use right url

* remove diff

---------

Co-authored-by: Hongtu Zhang (FA Talent) <v-hongtzhang@microsoft.com>
…If parameter (#20941)

* [AppService]: fix #16816- New-AzWebAppSSLBinding is missing the -WhatIf parameter

* ReRecorded the failed tests

* Updated changelog.md
* add it to New-AzDiskConfig

* help doc and change log

* suppress false positive

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
* breaking change message

* changelog

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
…rk with DigiCert hubs (#20938)

* IoT Hub SDK version update to 4.2.0 and fixed Get-AzIoTHub to work with DigiCert hubs

* Remove CertificateBodyDescription creation

* Reconfigure EventHubConsumerGroupName property

* update dps session records

* Fix DPS tests
* Move ServiceLinker to main

* Update Changelog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
* Move ManagedServiceIdentity to main

* Update Changelog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
…20944)

* Fix Invoke-WebRequest in Win10 issue

* Add optional settings (+2 squashed commit)

Squashed commit:

[37a75ce] Add optional settings

[f90cd1a] Add optional settings

* Install azure-arc helm release in azure-arc-release namespace (+1 squashed commits)

Squashed commits:

[49e9e01] Install azure-arc helm release in azure-arc-release namespace (+1 squashed commits)

Squashed commits:

[9662ecf] Install azure-arc helm release in azure-arc-release namespace

* Fix RSAHelper format

* Add Proxy settings (+1 squashed commits)

Squashed commits:

[28ff1d7] Add Proxy settings (+4 squashed commit)

Squashed commit:

[cdfe615] Update warning messages

[5d46ec2] Check credential

[db0351e] Update parameter description

[79bf2b1] Modify parameter type

* Fix Invalid URI issue when passing diaplsy name of location (+1 squashed commits)

Squashed commits:

[c893de7] Fix Invalid URI issue when passing diaplsy name of location (+1 squashed commits)

Squashed commits:

[bc81f1915fb] Fix Invalid URI issue when passing diaplsy name of location

* Update examples

* Update ChangeLog

* Update parameter names and docs
* Test Sync docs between 2 repos under NoriZC

* Change to absolute temp location

* Split file while copying to doc repo

* Change branch name to checkout

* Change pr org

* Change file location

* Change file location 2

* Switch HEAD and Base

* Switch to MicrosoftDocs org and azure-bot.

* Add header to markdown file.

* Remove indents of header

* Set Create PR process as optional

* Try to skip pr when existed.

* Try to skip pr when existed

* Update pr description

* Update tools/SyncDocs.ps1

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Make the script name clear and add some comments.

* Update ps1 path

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
GokulPrasad-Work and others added 4 commits February 17, 2023 14:16
* Register Microsoft.Monitor RP in Network cmdlet

Adding Microsoft.Monitor RP in Network PrivateLinkService cmdlet

Microsoft.Monitor RP supports
 - List Private Link Resource API
 - Get Private Endpoint Connection API
 - List Private Endpoint Connection API

It doesn't support Get Private Link Resource API yet

* Update Network change log

* Update src/Network/Network/ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
* Clean Az.ConnectedKubernetes

* Move ConnectedKubernetes to tmp/Az.ConnectedKubernetes (#20957)

* Update src/ConnectedKubernetes/Properties/AssemblyInfo.cs

---------

Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
* Set up first CI try with Azure Pipelines

description here! [skip ci]

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* commit me

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* remove test yml

* fresh new branch

* fresh new branch

* Add new static analysis phase

* fix md name

* change PipelineReult json

* change PipelineReult json

* Set moduleInfo.Status to Succeeded

---------

Co-authored-by: Hongtu Zhang (FA Talent) <v-hongtzhang@microsoft.com>
Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>
@blueww blueww added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Feb 20, 2023
BethanyZhou and others added 2 commits February 20, 2023 14:14
* [Relay]add breaking change for cmdlets.

* [Relay]updated changelog.md.

* [Relay]add target version for breaking change.
@blueww
Copy link
Member Author

blueww commented Feb 20, 2023

@BethanyZhou

Would you please help to look how to resolve the staticanalysis failure: https://dev.azure.com/azclitools/public/_build/results?buildId=35436&view=logs&j=b9afb22f-0837-5d02-bc24-6c30aee08bcf&t=990f6f37-4a21-5927-092a-220f38a460e9

the cmdlets for the failure are not owned by me.

* Move ServiceBus to main

* Update ChangeLog.md

---------

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
@BethanyZhou
Copy link
Contributor

There are some conflicts need to be fixed. Please have a look.

@blueww
Copy link
Member Author

blueww commented Feb 20, 2023

There are some conflicts need to be fixed. Please have a look.

conflict fixed.

@blueww
Copy link
Member Author

blueww commented Feb 20, 2023

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We ignore examples issues below this time, because they don't belong to storage team

 D:\a\_work\1\s\artifacts//StaticAnalysisResults\ExampleIssues.csv Errors
  "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
  "Az.MachineLearningServices","New-AzMLWorkspaceKubernetesObject","1","0","MissingExampleOutput","5045","1","Output of the example is missing.","D:\a\_work\1\s\src\MachineLearningServices\help\New-AzMLWorkspaceKubernetesObject.md","Add output for the example. Remove any placeholders."
  "Az.MachineLearningServices","New-AzMLWorkspaceTritonModelJobInputObject","2","0","MissingExampleTitle","5043","1","Title of the example is missing.","D:\a\_work\1\s\src\MachineLearningServices\help\New-AzMLWorkspaceTritonModelJobInputObject.md","Add title for the example. Remove any placeholders."
  "Az.MachineLearningServices","New-AzMLWorkspaceTritonModelJobInputObject","2","0","MissingExampleCode","5044","1","Code of the example is missing.","D:\a\_work\1\s\src\MachineLearningServices\help\New-AzMLWorkspaceTritonModelJobInputObject.md","Add code for the example. Remove any placeholders."
  "Az.MachineLearningServices","New-AzMLWorkspaceTritonModelJobInputObject","2","0","MissingExampleOutput","5045","1","Output of the example is missing.","D:\a\_work\1\s\src\MachineLearningServices\help\New-AzMLWorkspaceTritonModelJobInputObject.md","Add output for the example. Remove any placeholders."
  "Az.MachineLearningServices","New-AzMLWorkspaceTritonModelJobInputObject","2","0","MissingExampleDescription","5046","1","Description of the example is missing.","D:\a\_work\1\s\src\MachineLearningServices\help\New-AzMLWorkspaceTritonModelJobInputObject.md","Add description for the example. Remove any placeholders."
  "Az.CosmosDB","New-AzCosmosDBAccount","2","1","Invalid_Parameter_Name","5011","1","New-AzCosmosDBAccount -SourceRestorableDatabaseAccountId is not a valid parameter name.","-SourceRestorableDatabaseAccountId","Check validity of the parameter -SourceRestorableDatabaseAccountId."
  "Az.CosmosDB","New-AzCosmosDBAccount","2","1","Invalid_Parameter_Name","5011","1","New-AzCosmosDBAccount -RestoreTimesampInUtc is not a valid parameter name.","-RestoreTimesampInUtc","Check validity of the parameter -RestoreTimesampInUtc."
  "Az.CosmosDB","New-AzCosmosDBAccount","3","1","Invalid_Parameter_Name","5011","1","New-AzCosmosDBAccount -SourceDatabaseAccountName is not a valid parameter name.","-SourceDatabaseAccountName","Check validity of the parameter -SourceDatabaseAccountName."
  "Az.CosmosDB","New-AzCosmosDBAccount","3","1","Invalid_Parameter_Name","5011","1","New-AzCosmosDBAccount -RestoreTimesampInUtc is not a valid parameter name.","-RestoreTimesampInUtc","Check validity of the parameter -RestoreTimesampInUtc."
  "Az.EventGrid","Get-AzEventGridSystemTopic","3","3","Unbinded_Expression","5014","1","Get-AzEventGridSystemTopic $result.NextLink is not explicitly assigned to a parameter.","$result.NextLink","Assign $result.NextLink explicitly to the parameter."
  "Az.EventGrid","Get-AzEventGridSystemTopic","5","3","Unbinded_Expression","5014","1","Get-AzEventGridSystemTopic $result.NextLink is not explicitly assigned to a parameter.","$result.NextLink","Assign $result.NextLink explicitly to the parameter."
  "Az.EventGrid","Get-AzEventGridSystemTopicEventSubscription","4","2","Invalid_Parameter_Name","5011","1","Get-AzEventGridSystemTopicEventSubscription -TopicName is not a valid parameter name.","-TopicName","Check validity of the parameter -TopicName."
  "Az.EventGrid","Get-AzEventGridSystemTopicEventSubscription","4","3","Invalid_Parameter_Name","5011","1","Get-AzEventGridSystemTopicEventSubscription -TopicName is not a valid parameter name.","-TopicName","Check validity of the parameter -TopicName."
  "Az.EventGrid","Get-AzEventGridSystemTopicEventSubscription","4","3","Unbinded_Expression","5014","1","Get-AzEventGridSystemTopicEventSubscription $result.NextLink is not explicitly assigned to a parameter.","$result.NextLink","Assign $result.NextLink explicitly to the parameter."
  "Az.EventGrid","New-AzEventGridSystemTopicEventSubscription","1","1","Invalid_Parameter_Name","5011","1","New-AzEventGridSystemTopicEventSubscription -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "Az.EventGrid","New-AzEventGridSystemTopicEventSubscription","2","3","Invalid_Parameter_Name","5011","1","New-AzEventGridSystemTopicEventSubscription -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "Az.EventGrid","New-AzEventGridSystemTopicEventSubscription","3","1","Invalid_Parameter_Name","5011","1","New-AzEventGridSystemTopicEventSubscription -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "Az.EventGrid","Remove-AzEventGridSystemTopicEventSubscription","1","1","Invalid_Parameter_Name","5011","1","Remove-AzEventGridSystemTopicEventSubscription -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "Az.EventGrid","Update-AzEventGridSystemTopicEventSubscription","1","1","Invalid_Parameter_Name","5011","1","Update-AzEventGridSystemTopicEventSubscription -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "Az.EventGrid","Update-AzEventGridSystemTopicEventSubscription","2","2","Invalid_Parameter_Name","5011","1","Update-AzEventGridSystemTopicEventSubscription -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "Az.EventGrid","Update-AzEventGridSystemTopicEventSubscription","3","1","Invalid_Parameter_Name","5011","1","Update-AzEventGridSystemTopicEventSubscription -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "Az.MachineLearningServices","Remove-AzMLWorkspaceConnection","1","1","Invalid_Parameter_Name","5011","1","Remove-AzMLWorkspaceConnection -ConnectionName is not a valid parameter name.","-ConnectionName","Check validity of the parameter -ConnectionName."
  "Az.MachineLearningServices","Remove-AzMLWorkspaceConnection","2","1","Invalid_Parameter_Name","5011","1","Get-AzMLWorkspaceConnection -ConnectionName is not a valid parameter name.","-ConnectionName","Check validity of the parameter -ConnectionName."
  "Az.Security","Set-AzSecurityAutomation","1","1","Invalid_Parameter_Name","5011","1","Set-AzSecurityAutomation -Scopes is not a valid parameter name.","-Scopes","Check validity of the parameter -Scopes."
  "Az.Security","Set-AzSecurityAutomation","1","1","Invalid_Parameter_Name","5011","1","Set-AzSecurityAutomation -Sources is not a valid parameter name.","-Sources","Check validity of the parameter -Sources."
  "Az.Security","Set-AzSecurityAutomation","1","1","Invalid_Parameter_Name","5011","1","Set-AzSecurityAutomation -Actions is not a valid parameter name.","-Actions","Check validity of the parameter -Actions."```

@BethanyZhou
Copy link
Contributor

@isra-fel could you help force-merge this PR. Please pay attention to 'Do not Squash'.

@isra-fel isra-fel merged commit c8fe4ef into Az.Storage-preview Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.