Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Az.SqlVirtualMachine XML comments #18582

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fix Az.SqlVirtualMachine XML comments #18582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...qlVirtualMachine/AvailabilityGroupListener/Cmdlet/UpdateAzureAvailabilityGroupListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ protected override IEnumerable<AzureAvailabilityGroupListenerModel> GetEntity()
/// <summary>
/// Apply user input to the retrieved Availability Group Listener
/// </summary>
/// <param name="model">The Availability Group Listener that will be updated<param>
/// <param name="model">The Availability Group Listener that will be updated</param>
/// <returns>The model to send to the update</returns>
protected override IEnumerable<AzureAvailabilityGroupListenerModel> ApplyUserInputToModel(IEnumerable<AzureAvailabilityGroupListenerModel> model)
{
Expand Down
4 changes: 2 additions & 2 deletions src/SqlVirtualMachine/SqlVirtualMachine/SqlVirtualMachine/Cmdlet/UpdateAzureSqlVM.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,15 +186,15 @@ protected override IEnumerable<AzureSqlVMModel> GetEntity()
/// <summary>
/// Apply user input to the retrieved sql virtual machine.
/// </summary>
/// <param name="model">The sql virtual machine that will be updated<param>
/// <param name="model">The sql virtual machine that will be updated</param>
/// <returns>The model to send to the update</returns>
protected override IEnumerable<AzureSqlVMModel> ApplyUserInputToModel(IEnumerable<AzureSqlVMModel> model)
{
List<AzureSqlVMModel> updateData = new List<AzureSqlVMModel>();
AzureSqlVMModel sqlVM = model.FirstOrDefault();
if (ParameterSetName.EndsWith(ParameterSet.InputObject))
{
sqlVM.Offer = InputObject.Offer ?? sqlVM.Offer;
sqlVM.Offer = InputObject.Offer ?? sqlVM.Offer;
sqlVM.Sku = InputObject.Sku ?? sqlVM.Sku;
sqlVM.LicenseType = InputObject.LicenseType ?? sqlVM.LicenseType;
sqlVM.SqlManagementType = InputObject.SqlManagementType ?? sqlVM.SqlManagementType;
Expand Down
6 changes: 2 additions & 4 deletions src/SqlVirtualMachine/SqlVirtualMachine/SqlVirtualMachine/Services/AzureSqlVMAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public AzureSqlVMModel UpsertSqlVirtualMachine(AzureSqlVMModel model)
/// Deletes a sql virtual machine
/// </summary>
/// <param name="resourceGroupName">The resource group the sql virtual machine is in</param>
/// <param name="serverName">The name of the sql virtual machine to delete</param>
/// <param name="sqlVirtualMachineName">The name of the sql virtual machine to delete</param>
public void RemoveSqlVirtualMachine(string resourceGroupName, string sqlVirtualMachineName)
{
Communicator.Delete(resourceGroupName, sqlVirtualMachineName);
Expand All @@ -86,7 +86,6 @@ public void RemoveSqlVirtualMachine(string resourceGroupName, string sqlVirtualM
/// <summary>
/// Gets a list of all the sql virtual machines in a subscription
/// </summary>
/// <param name="resourceGroupName">The name of the resource group</param>
/// <returns>A list of all the sql virtual machines</returns>
public List<AzureSqlVMModel> ListSqlVirtualMachine()
{
Expand Down Expand Up @@ -115,7 +114,7 @@ public List<AzureSqlVMModel> ListSqlVirtualMachineByResourceGroup(string resourc
/// Gets a sql virtual machine in a resource group
/// </summary>
/// <param name="resourceGroupName">The name of the resource group</param>
/// <param name="serverName">The name of the sql virtual machine</param>
/// <param name="sqlVirtualMachineName">The name of the sql virtual machine</param>
/// <returns>The sql virtual machine</returns>
public AzureSqlVMModel GetSqlVirtualMachine(string resourceGroupName, string sqlVirtualMachineName)
{
Expand All @@ -126,7 +125,6 @@ public AzureSqlVMModel GetSqlVirtualMachine(string resourceGroupName, string sql
/// <summary>
/// Convert a Management.SqlVirtualMachine.Models.SqlVirtualMachineModel to AzureSqlVirtualMachineModel
/// </summary>
/// <param name="resourceGroupName">The resource group the sql virtual machine is in</param>
/// <param name="resp">The management client sql virtual machine response to convert</param>
/// <returns>The converted sql virtual machine model</returns>
private AzureSqlVMModel CreateSqlVirtualMachineModelFromResponse(SqlVirtualMachineModel resp)
Expand Down
6 changes: 3 additions & 3 deletions ...rtualMachine/SqlVirtualMachine/SqlVirtualMachineGroup/Cmdlet/AzureSqlVMGroupCmdletBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ protected override AzureSqlVMGroupAdapter InitModelAdapter()
/// <summary>
/// Validate the resource id of a sql virtual machine group
/// </summary>
/// <param name="sqlVirtualMachineResourceId">Resource id to be validated</param>
/// <param name="sqlVirtualMachineGroupId">Resource id to be validated</param>
/// <returns>True if the resource id is valid, false otherwise</returns>
public bool ValidateSqlVirtualMachineGroupId(string sqlVirtualMachineGroupId)
{
Expand All @@ -70,7 +70,7 @@ public bool ValidateSqlVirtualMachineGroupId(string sqlVirtualMachineGroupId)
/// <summary>
/// Get the resource group name of a sql virtual machine group from its resource id
/// </summary>
/// <param name="sqlVirtualMachineId">Resource id of the sql virtual machine</param>
/// <param name="sqlVirtualMachineGroupId">Resource id of the sql virtual machine</param>
/// <returns>Resource group name contained in the resource id</returns>
public string GetResourceGroupNameFromId(string sqlVirtualMachineGroupId)
{
Expand All @@ -80,7 +80,7 @@ public string GetResourceGroupNameFromId(string sqlVirtualMachineGroupId)
/// <summary>
/// Get the name of a sql virtual machine from its resource id
/// </summary>
/// <param name="sqlVirtualMachineId">Resource id of the sql virtual machine</param>
/// <param name="sqlVirtualMachineGroupId">Resource id of the sql virtual machine</param>
/// <returns>Resource name contained in the resource id</returns>
public string GetResourceNameFromId(string sqlVirtualMachineGroupId)
{
Expand Down
2 changes: 1 addition & 1 deletion ...qlVirtualMachine/SqlVirtualMachine/SqlVirtualMachineGroup/Cmdlet/UpdateAzureSqlVMGroup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ protected override IEnumerable<AzureSqlVMGroupModel> GetEntity()
/// <summary>
/// Apply user input to the retrieved sql virtual machine group
/// </summary>
/// <param name="model">The sql virtual machine group that will be updated<param>
/// <param name="model">The sql virtual machine group that will be updated</param>
/// <returns>The model to send to the update</returns>
protected override IEnumerable<AzureSqlVMGroupModel> ApplyUserInputToModel(IEnumerable<AzureSqlVMGroupModel> model)
{
Expand Down
6 changes: 2 additions & 4 deletions ...irtualMachine/SqlVirtualMachine/SqlVirtualMachineGroup/Services/AzureSqlVMGroupAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public AzureSqlVMGroupModel UpsertSqlVirtualMachineGroup(AzureSqlVMGroupModel mo
/// Deletes a sql virtual machine group
/// </summary>
/// <param name="resourceGroupName">The resource group the sql virtual machine goup is in</param>
/// <param name="serverName">The name of the sql virtual machine group to delete</param>
/// <param name="sqlVirtualMachineName">The name of the sql virtual machine group to delete</param>
public void RemoveSqlVirtualMachine(string resourceGroupName, string sqlVirtualMachineName)
{
Communicator.Delete(resourceGroupName, sqlVirtualMachineName);
Expand All @@ -80,7 +80,6 @@ public void RemoveSqlVirtualMachine(string resourceGroupName, string sqlVirtualM
/// <summary>
/// Gets a list of all the sql virtual machine groups in a subscription
/// </summary>
/// <param name="resourceGroupName">The name of the resource group</param>
/// <returns>A list of all the sql virtual machine groups</returns>
public List<AzureSqlVMGroupModel> ListSqlVirtualMachineGroup()
{
Expand Down Expand Up @@ -109,7 +108,7 @@ public List<AzureSqlVMGroupModel> ListSqlVirtualMachineGroupByResourceGroup(stri
/// Gets a sql virtual machine group in a resource group
/// </summary>
/// <param name="resourceGroupName">The name of the resource group</param>
/// <param name="serverName">The name of the sql virtual machine group</param>
/// <param name="groupName">The name of the sql virtual machine group</param>
/// <returns>The sql virtual machine group</returns>
public AzureSqlVMGroupModel GetSqlVirtualMachineGroup(string resourceGroupName, string groupName)
{
Expand All @@ -120,7 +119,6 @@ public AzureSqlVMGroupModel GetSqlVirtualMachineGroup(string resourceGroupName,
/// <summary>
/// Convert a Management.SqlVirtualMachine.Models.SqlVirtualMachineGroupModel to AzureSqlVirtualMachineGroupModel
/// </summary>
/// <param name="resourceGroupName">The resource group the sql virtual machine group is in</param>
/// <param name="resp">The management client sql virtual machine group response to convert</param>
/// <returns>The converted sql virtual machine group model</returns>
private static AzureSqlVMGroupModel CreateSqlVirtualMachineGroupModelFromResponse(SqlVirtualMachineGroup resp)
Expand Down