Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Az.NetWork XML Comments #18461

Merged
merged 2 commits into from
Jun 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Network/Network/Common/NetworkClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,12 @@ public async Task<string> GenerateP2SVpnGatewayVpnProfileAsync(string resourceGr
/// <param name='parameters'>
/// Parameters supplied to the Begin the operation through Network resource provider.
/// </param>
/// <param name="apiUrl">
/// The api URL of the resource.
/// </param>
/// <param name="apiVersion">
/// The api version of the resource.
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// </param>
Expand Down
8 changes: 4 additions & 4 deletions src/Network/Network/Models/PSSecurityGroupNetworkInterface.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ public string SecurityRuleAssociationsText
get { return JsonConvert.SerializeObject(this.SecurityRuleAssociations, Formatting.Indented, new JsonSerializerSettings() { NullValueHandling = NullValueHandling.Ignore }); }
}

/// public bool ShouldSerializeIpConfigurations()
/// {
/// return !string.IsNullOrEmpty(this.Name);
/// }
// public bool ShouldSerializeIpConfigurations()
// {
// return !string.IsNullOrEmpty(this.Name);
// }
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
// limitations under the License.
// ----------------------------------------------------------------------------------

using Microsoft.Rest;
using Newtonsoft.Json;

namespace Microsoft.Azure.Commands.Network.PrivateLinkService.Models
Expand Down Expand Up @@ -42,6 +43,7 @@ public PrivateEndpointConnection()
/// the private endpoint connection.</param>
/// <param name="provisioningState">State of the private endpoint
/// connection.</param>
/// <param name="groupId">Group ID of the private endpoint.</param>
public PrivateEndpointConnection(string id = default(string), string name = default(string), string type = default(string), PrivateEndpointProperty privateEndpoint = default(PrivateEndpointProperty), PrivateLinkServiceConnectionStateProperty privateLinkServiceConnectionState = default(PrivateLinkServiceConnectionStateProperty), string provisioningState = default(string), string groupId = default(string))
: base(id, name, type)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public PrivateLinkResourceProperties()
/// <param name="groupId">The private link resource group id.</param>
/// <param name="requiredMembers">The private link resource required
/// member names.</param>
/// <param name="requiredZoneNames">The private link resource required zone names.</param>
public PrivateLinkResourceProperties(string groupId = default(string), IList<string> requiredMembers = default(IList<string>), IList<string> requiredZoneNames = default(IList<string>))
{
GroupId = groupId;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ public static ProviderConfiguration GetProviderConfiguration(string type)
/// Generate a runtime parameter with ValidateSet matching the current context
/// </summary>
/// <param name="name">The name of the parameter</param>
/// <param name="parameterSetName">The name of the parameter set</param>
/// <param name="runtimeParameter">The returned runtime parameter for context, with appropriate validate set</param>
/// <returns>True if one or more contexts were found, otherwise false</returns>
public static bool TryGetEndpointConnectionServiceParameter(string name, string parameterSetName, out RuntimeDefinedParameter runtimeParameter)
Expand Down Expand Up @@ -140,6 +141,7 @@ public static bool TryGetEndpointConnectionServiceParameter(string name, string
/// Generate a runtime parameter with ValidateSet matching the current context
/// </summary>
/// <param name="name">The name of the parameter</param>
/// <param name="parameterSetName">The name of the parameter set</param>
/// <param name="runtimeParameter">The returned runtime parameter for context, with appropriate validate set</param>
/// <returns>True if one or more contexts were found, otherwise false</returns>
public static bool TryGetLinkResourceServiceParameter(string name, string parameterSetName, out RuntimeDefinedParameter runtimeParameter)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ private PSSecurityPartnerProvider CreateSecurityPartnerProvider()

string virtualHubResourceGroupName = this.ResourceGroupName; // default to common RG
var resolvedVirtualHub = new VirtualHub();
/// Resolve and Set the Virtual HUb
// Resolve and Set the Virtual Hub
if (this.VirtualHubId != null) // When Id is provided
{
var resourceInfo = new ResourceIdentifier(VirtualHubId);
Expand Down