Update AmqpSend.java #2
Conversation
Cloud 2 Device client hanging and doesn't throw any error when the connection string is incorrect Azure#938
|
@enuysa-msft - Since this is a code change, can you please submit it against the develop branch? Thanks. |
|
@tameraw - Done. I have submitted it to the develop branch |
| { | ||
| this.reactor.run(); | ||
| } | ||
| catch (Exception e) { |
There was a problem hiding this comment.
I think it would be nice to throw exception to higher layers and notify then to catch it here.
|
@enuysa-msft - This still appears to be against master. Can you please resubmit against develop and address feedback from @prmathur-microsoft? |
|
@enuysa-msft - Please address comments and resubmit against develp branch. |
|
I have resubmitted the change at developer branch but I will check and try to throw exception to higher layers |
|
@prmathur-microsoft - I have checked throw exception to higher layers but the higher layer is |
* standardize on command-line arguments (replace env variables) * Updates based on PR feedbacks * updated with TimeUnit and log based on feedback. * update sample using commonsCli for command line argument processing * update sample using commonsCli for command line argument processing * updates from PR feedback * updates from PR feedback #2 Co-authored-by: Andy Kwong <andykwong@microsoft.com>
Cloud 2 Device client hanging and doesn't throw any error when the connection string is incorrect
https://github.com/Azure/azure-iot-sdks/issues/938