-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): Honor keepalive when using security provider #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdavi
requested review from
abhipsaMisra,
azabbasi,
brycewang-microsoft,
drwill-ms and
timtay-microsoft
as code owners
January 20, 2022 17:25
timtay-microsoft
approved these changes
Jan 20, 2022
jamdavi
commented
Jan 20, 2022
...e/iot-device-client/src/main/java/com/microsoft/azure/sdk/iot/device/DeviceClientConfig.java
Outdated
Show resolved
Hide resolved
…/iot/device/DeviceClientConfig.java
jamdavi
commented
Jan 20, 2022
...e/iot-device-client/src/main/java/com/microsoft/azure/sdk/iot/device/DeviceClientConfig.java
Outdated
Show resolved
Hide resolved
…/iot/device/DeviceClientConfig.java
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
jamdavi
commented
Jan 24, 2022
...e/iot-device-client/src/test/java/com/microsoft/azure/sdk/iot/device/InternalClientTest.java
Outdated
Show resolved
Hide resolved
jamdavi
commented
Jan 24, 2022
...e/iot-device-client/src/test/java/com/microsoft/azure/sdk/iot/device/InternalClientTest.java
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a security provider the keep alive defined in the ClientOptions is not set.