feat(dps-dev): Add missing registration result fields #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtay-microsoft
requested review from
abhipsaMisra,
azabbasi,
drwill-ms,
jamdavi and
vinagesh
as code owners
| @@ -7,12 +7,33 @@ | |||
|
|
|||
| package com.microsoft.azure.sdk.iot.provisioning.device; | |||
|
|
|||
| import lombok.Getter; | |||
|
|
|||
| public class ProvisioningDeviceClientRegistrationResult | |||
There was a problem hiding this comment.
This is the public facing class that our provisioning device client returns to a user after a successful device registration. Previously, it only had the essential fields exposed, but now it exposes all the fields that the service gives us.
| public enum ProvisioningDeviceClientSubstatus | ||
| { | ||
| /** | ||
| * Device has been assigned to an IoT hub for the first time |
There was a problem hiding this comment.
These javadocs are copied directly from the service swagger
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
vinagesh
approved these changes
Aug 17, 2021
The service has sent these fields for a while, but we never exposed them to users for some reason. This brings our registration result class up to par with what the service sends to the SDK
timtay-microsoft
force-pushed
the
timtay/provisioningFix
branch
from
a01cc02 to
fd76f2b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
jamdavi
approved these changes
Aug 17, 2021
.../java/com/microsoft/azure/sdk/iot/provisioning/device/ProvisioningDeviceClientSubstatus.java
Outdated
Show resolved
Hide resolved
Comment on lines
+31
to
+60
|
|
||
| void setRegistrationId(String registrationId) | ||
| { | ||
| this.registrationId = registrationId; | ||
| } | ||
|
|
||
| void setCreatedDateTimeUtc(String createdDateTimeUtc) | ||
| { | ||
| this.createdDateTimeUtc = createdDateTimeUtc; | ||
| } | ||
|
|
||
| void setStatus(String status) | ||
| { | ||
| this.status = status; | ||
| } | ||
|
|
||
| void setSubstatus(ProvisioningDeviceClientSubstatus substatus) | ||
| { | ||
| this.substatus = substatus; | ||
| } | ||
|
|
||
| void setETag(String eTag) | ||
| { | ||
| this.eTag = eTag; | ||
| } | ||
|
|
||
| void setLastUpdatesDateTimeUtc(String lastUpdatesDateTimeUtc) | ||
| { | ||
| this.lastUpdatesDateTimeUtc = lastUpdatesDateTimeUtc; | ||
| } |
There was a problem hiding this comment.
Any reason not to use Lombok? Might save us some code.
There was a problem hiding this comment.
The reason I'm not using lombok here is because the fields themselves are defined in the super class. I'd add some protected or package private lombok setters in the super class instead, but the setters are only used within this class's package, and it wouldn't make sense to publicly expose setters for this read-only class
…osoft/azure/sdk/iot/provisioning/device/ProvisioningDeviceClientSubstatus.java Co-authored-by: jamdavi <73593426+jamdavi@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
timtay-microsoft
added a commit
that referenced
this pull request
Aug 27, 2021
The service has sent these fields for a while, but we never exposed them to users for some reason. This brings our registration result class up to par with what the service sends to the SDK Also add a small bug fix to a multiplexing client test
timtay-microsoft
added a commit
that referenced
this pull request
Aug 27, 2021
The service has sent these fields for a while, but we never exposed them to users for some reason. This brings our registration result class up to par with what the service sends to the SDK Also add a small bug fix to a multiplexing client test
timtay-microsoft
added a commit
that referenced
this pull request
Aug 27, 2021
The service has sent these fields for a while, but we never exposed them to users for some reason. This brings our registration result class up to par with what the service sends to the SDK Also add a small bug fix to a multiplexing client test
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service has sent these fields for a while, but we never exposed them to users for some reason. This brings our registration result class up to par with what the service sends to the SDK