Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross target framework dependency management #1599

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

abhipsaMisra
Copy link
Member

@abhipsaMisra abhipsaMisra commented Oct 7, 2020

Since net451 is the only tfm < ns2.0 that we target, Instead of adding an explicit check for each supported tfm greater than ns2.0, we can simply check if the tfm != net451.

Fix for #1562 , #1592

@abhipsaMisra
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@abhipsaMisra
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@bikamani
Copy link
Contributor

bikamani commented Oct 7, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@BertKleewein
Copy link
Member

/azp list

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1599 in repo Azure/azure-iot-sdk-csharp

@abhipsaMisra
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abhipsaMisra abhipsaMisra merged commit f99b0e8 into master Oct 8, 2020
@abhipsaMisra abhipsaMisra deleted the abmisr/tfmManage branch October 8, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants