-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report failures to Azure via Wireserver with KVP Fallback #170
Draft
peytonr18
wants to merge
4
commits into
Azure:main
Choose a base branch
from
peytonr18:probertson-report-failure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7f05c0
to
f8be2fe
Compare
…lure events; adding unit tests to check formatting according to cloud-init documentation; adding a KVP entry for provisioning success
b9d440e
to
c120b01
Compare
To Do items here:
|
…alth_report, simplifying on_event handling.
09e5f87
to
8ce2f99
Compare
There is a new endpoint which does not require us to fetch goal state and uses json instead of xml.
We don't have to do it in this PR, but I would like to switch over to the new endpoint to avoid dealing with goalstate. The one upside to fetching goalstate is getting the container id. |
37e441e
to
24c4c29
Compare
…() so we can't emit traces there. Instead, move report_success to the provisioing_result block and check for success there or go to failure logic.
24c4c29
to
33297d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces failure reporting for provisioning. The changes ensure that if provisioning fails, the error is reported to Azure either via wireserver or, as a fallback, via KVP .
Key Changes
XML Payload for Failure Reporting:
build_report_failure_file
andreport_failure()
functions.<State>
is set to"NotReady"
,<Substatus>
is set to"ProvisioningFailed"
, and<Description>
contains a user-visible error message.Integration in the Provisioning Flow:
provision()
function, when a provisioning error occurs:report_failure()
is called with the appropriate error description.tracing::error!
as a fallback.Next Steps
report_failure()
(could use some insight into how best mimic the sever/request dynamic) and further refine the implementation if needed.Resolves #58.