Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK to redirect .NET 6 apps to use the custom host (V0) #658

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Update SDK to redirect .NET 6 apps to use the custom host (V0) #658

merged 3 commits into from
Sep 17, 2024

Conversation

surgupta-msft
Copy link
Contributor

Resolves #657

@surgupta-msft surgupta-msft marked this pull request as ready for review September 11, 2024 23:13
mattchenderson
mattchenderson requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@mattchenderson mattchenderson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version number as well (I believe this should be 4.5.0). Otherwise, the changes look good.

Additional note: We should get this into good standing, but the SDK should not be immediately released. Other prerequisite work must land before this can be shipped.

@mattchenderson mattchenderson mentioned this pull request Sep 16, 2024
Merged
@surgupta-msft
Copy link
Contributor Author

Please update the version number as well (I believe this should be 4.5.0). Otherwise, the changes look good.

Additional note: We should get this into good standing, but the SDK should not be immediately released. Other prerequisite work must land before this can be shipped.

Updated the version number. Let me know if it is okay to merge the PR now but not release the sdk till prerequisites are done.

@mattchenderson
Copy link
Contributor

Please update the version number as well (I believe this should be 4.5.0). Otherwise, the changes look good.
Additional note: We should get this into good standing, but the SDK should not be immediately released. Other prerequisite work must land before this can be shipped.

Updated the version number. Let me know if it is okay to merge the PR now but not release the sdk till prerequisites are done.

Yes, I think we should merge to get things lined up. It's just the release itself we'll want to wait on.

@surgupta-msft surgupta-msft merged commit 1f7d863 into main Sep 17, 2024
1 check passed
@surgupta-msft surgupta-msft deleted the surgupta/inproc-net6 branch September 17, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattchenderson mattchenderson mattchenderson approved these changes

@liliankasem liliankasem liliankasem approved these changes

@kshyju kshyju Awaiting requested review from kshyju

@fabiocav fabiocav Awaiting requested review from fabiocav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update SDK to redirect .NET 6 apps to use the custom host (V0)
3 participants
@surgupta-msft @mattchenderson @liliankasem