Add Easy Auth local settings file to git ignore, project template #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glennamanns , I don't think this is the right change. We shouldn't be adding any additional files to the default template which is an opt in feature. Instead this should be a CLI command like proxies. |
|
Closing PR based on @soninaren's comment. I will instead programmatically add local.middleware.json to the Function's .csproj during the create-aad command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a larger goal to enable Easy Auth to run locally. The relevant Azure Functions CLI PR is here: Azure/azure-functions-core-tools#789
The CLI PR is currently blocked/waiting on the Easy Auth Linux+Windows combine, and this templates PR should be merged about the same time as that one.