Default log level to debug #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
MaddyDev,
chlafreniere and
lucyzhang929
as code owners
chlafreniere
approved these changes
Nov 14, 2022
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* Default log level to debug * update min timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #438
This is primarily for our tests, although when I'm running locally I usually have debug enabled too.
Along with this I updated the min timeout value since all that extra logging does eat up extra processing time. 10sec is probably a lot more than most cases need but given that these tests care about correctness and not necessarily performance that seems fine (and trying to guess what the exact execution time is going to be would be very difficult).
This does mean that if users are copying the host.json directly they may have this enabled by accident too - but it's easy enough to change and is something I think that's actually useful for them to know about so doesn't seem like a terrible thing to have. (plus most people are going to create a new function and then copy the code over directly instead of copying the entire samples folder so this probably isn't even going to be a thing most people run in to).