Move extension files to subfolder #189
Conversation
JatinSanghvi
force-pushed
the
reorder-files
branch
2 times, most recently
from
4391f6b
to
23dbf37
Compare
| @@ -22,7 +22,7 @@ | |||
| │ ├───Microsoft.Azure.WebJobs.Extensions.RabbitMQ.2.0.0-preview.symbols.nupkg | |||
| │ └───_manifest | |||
| │ └───<files> | |||
| └───drop-java-bindings | |||
| └───drop-java-library | |||
| └───2.0.0-preview | |||
| ├───_manifest | |||
| │ └───<files> | |||
There was a problem hiding this comment.
Modified three files: RELEASE_PROCESS.md, azure-pipeline.yml, and .gitignore. Rest of all files are only shifted to different folders.
| @@ -29,7 +29,7 @@ jobs: | |||
| displayName: WebJobs extension | |||
| steps: | |||
| - powershell: | # Allow tags matching v1.2.3 and v1.2.3-xyz1 | |||
| $found = '$(Build.SourceBranchName)' | Select-String -Pattern '^v((\d+\.\d+\.\d+)(?:-\w+))*$' | |||
| $found = '$(Build.SourceBranchName)' | Select-String -Pattern '^v((?:0|[1-9]\d*)\.(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)(?:-\w+)?)$' | |||
| if (-not $found) { | |||
There was a problem hiding this comment.
The earlier pattern was incorrect (don't remember why I even committed it like this 🤦). It did not allow a tag like v2.0.0 which is intended tag for next major release.
There was a problem hiding this comment.
I should have also look at it it carefully the previous time, my bad.
There was a problem hiding this comment.
I don't think you reviewed the PR with this particular change :)
There was a problem hiding this comment.
I had added above PR comment soon after the making the first commit. I meant I should have checked the regex when I had worked on build pipeline 1-2 months back.
JatinSanghvi
force-pushed
the
reorder-files
branch
from
23dbf37
to
c20a94c
Compare
JatinSanghvi
force-pushed
the
reorder-files
branch
from
15bb032
to
265f6f1
Compare
|
Thanks for approving the PR, @v-shenoy. I found two issues with the build pipeline that impacted release builds. Please check the latest commit at your free time and approve the PR if things look good. |
Approved, @JatinSanghvi |
Keeping the root directory clean. Motivation for changes:
dotnet testwill see a .NET project structure, The CLI won't find Java files in first place to be able to ignore them.Fixed regex string used for parsing version tag. It was not allowing a version tag like
v2.0.0