Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connection-string elements from attributes #184

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

JatinSanghvi
Copy link
Contributor

@JatinSanghvi JatinSanghvi commented Feb 17, 2022

Current extension supports both RabbitMQ connection URI e.g. amqp://user:pass@host:10000/vhost and individual connection-string elements (user, pass, host, and 1000) to be specified in trigger and output bindings. With the latter way to specify connection information, some of the elements were still missing, namely isSslEnabled and vHost. We recently added commit to include attribute property for isSslEnabled. Instead of adding and maintaining these many number of attribute properties, this commit removes the latter support. This would also eliminate combinations like hostname coming from appsettings but port coming from attributes, which is not what we expect from users.

As per my research, most of the users use connection strings in their functions. Since next one would be a version 2.x release, I am taking the opportunity to introduce this breaking change. Users using connection strings already are not expected to update their functions to upgrade to v2.x release. The other WebJobs extensions from Azure only support connection strings, as far as I have seen.

@JatinSanghvi JatinSanghvi changed the title Remove connection-string elements attributes Remove connection-string elements from attributes Feb 17, 2022
Copy link
Member

@v-shenoy v-shenoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @JatinSanghvi.
The changes look thorough.

@JatinSanghvi JatinSanghvi merged commit ae75cde into Azure:dev Feb 21, 2022
@JatinSanghvi JatinSanghvi deleted the remove-connection-attributes branch February 21, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants