Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test Webhost logs and fix 503s #1411

Merged
merged 32 commits into from
Jan 31, 2024
Merged

Conversation

YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Jan 29, 2024

Description

  1. Add health check for test webhost after starting up
  2. Refactor webhost log after test
  3. Update deprecated github actions in pipelines
  4. Add a flag to archive webhost logs ad-hoc after tests all complete in the pipelines.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eef7628) 85.87% compared to head (f6b3483) 85.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1411      +/-   ##
==========================================
- Coverage   85.87%   85.46%   -0.41%     
==========================================
  Files          35       35              
  Lines        1968     1968              
  Branches      370      370              
==========================================
- Hits         1690     1682       -8     
- Misses        209      213       +4     
- Partials       69       73       +4     
Flag Coverage Δ
unittests 85.41% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YunchuWang YunchuWang marked this pull request as ready for review January 30, 2024 21:17
@YunchuWang YunchuWang changed the title add sanity check for testwebhost and refactor webhost log after test enhance test webhost logs/fix 503 Jan 31, 2024
@vrdmr vrdmr changed the title enhance test webhost logs/fix 503 Enhance test Webhost logs and fix 503s Jan 31, 2024
tests/utils/testutils.py Outdated Show resolved Hide resolved
tests/utils/testutils.py Outdated Show resolved Hide resolved
tests/utils/testutils.py Outdated Show resolved Hide resolved
tests/utils/testutils.py Outdated Show resolved Hide resolved
tests/utils/testutils.py Outdated Show resolved Hide resolved
tests/utils/testutils.py Outdated Show resolved Hide resolved
tests/utils/testutils.py Show resolved Hide resolved
@YunchuWang YunchuWang requested a review from vrdmr January 31, 2024 20:29
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@YunchuWang YunchuWang merged commit c681591 into dev Jan 31, 2024
44 of 51 checks passed
@YunchuWang YunchuWang deleted the wangbill/fix-testwebhost branch January 31, 2024 21:14
gavin-aguiar added a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants