Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for cust sys packages path #1335

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

hallvictoria
Copy link
Contributor

Description

Changes in worker and constants to fix "Customer packages not in sys path." warning log being hit.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1335 (baf4464) into dev (5909387) will decrease coverage by 53.63%.
The diff coverage is 50.00%.

❗ Current head baf4464 differs from pull request most recent head fc16528. Consider uploading reports for the commit fc16528 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1335       +/-   ##
===========================================
- Coverage   85.73%   32.11%   -53.63%     
===========================================
  Files          34       34               
  Lines        1942     1940        -2     
  Branches      367      367               
===========================================
- Hits         1665      623     -1042     
- Misses        210     1316     +1106     
+ Partials       67        1       -66     
Flag Coverage Δ
unittests 32.11% <50.00%> (-53.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
azure_functions_worker/constants.py 100.00% <100.00%> (ø)
azure_functions_worker/dispatcher.py 19.04% <0.00%> (-69.68%) ⬇️

... and 23 files with indirect coverage changes

@hallvictoria hallvictoria marked this pull request as ready for review October 26, 2023 19:00
azure_functions_worker/constants.py Outdated Show resolved Hide resolved
python/prodV4/worker.py Show resolved Hide resolved
@hallvictoria hallvictoria merged commit 42f67cc into dev Nov 7, 2023
@hallvictoria hallvictoria deleted the hallvictoria/fix-syspath-log branch November 7, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants