Configurable file name #1323
Merged
Configurable file name #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallvictoria
requested review from
vrdmr,
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1323 +/- ##
==========================================
+ Coverage 85.11% 85.84% +0.72%
==========================================
Files 35 35
Lines 1955 1971 +16
Branches 370 371 +1
==========================================
+ Hits 1664 1692 +28
+ Misses 217 210 -7
+ Partials 74 69 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vrdmr
reviewed
Nov 8, 2023
…-worker into hallvictoria/configurable_file_name
…-worker into hallvictoria/configurable_file_name
…com/Azure/azure-functions-python-worker into hallvictoria/configurable_file_name
…-worker into hallvictoria/configurable_file_name
…com/Azure/azure-functions-python-worker into hallvictoria/configurable_file_name
vrdmr
reviewed
Jan 10, 2024
gavin-aguiar
approved these changes
Jan 11, 2024
vrdmr
reviewed
Jan 11, 2024
|
|
||
| if not os.path.exists(function_path): | ||
| # Fallback to legacy model | ||
| logger.info("%s does not exist. " |
There was a problem hiding this comment.
Is this necessary to log in general? If this log can be merged in the earlier log itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Python worker reads the function app entry point from an app setting called
PYTHON_SCRIPT_FILE_NAME. The default value for this setting will still be "function_app.py". Customers can signal to the worker to read from a file not called "function_app.py" by setting this variable to the new name of their file.Added unit and e2e tests for this app setting by creating a function app file not called "function_app.py" and testing it.
Also added unit tests for 2 invalid V2 app scenarios: no top level function app instances and no inputs
Fixes #https://github.com/Azure/azure-functions-pyfx-planning/issues/72
PR information
Quality of Code and Contribution Guidelines