Add ASGI handler #86
Merged
Add ASGI handler #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaloney
requested review from
anirudhgarg,
Hazhzeng and
vrdmr
as code owners
|
@Hazhzeng this is ready for review now, �I've added some tests, mostly against the specification to validate types (byte strings vs unicode strings) The CI is failing, but it doesn't look to have anything todo with this change. |
Hazhzeng
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Thanks for contributing on azure.functions. I checked the code against the https://asgi.readthedocs.io, left a few comments. Please update the code. Overall, it looks perfect.
|
@Hazhzeng amendments made as per feedback. |
|
CI error is not a code issue, this is the related issue that our github has: actions/first-interaction#10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an ASGI middleware wrapper compatible with ASGI 2.1
Closes #75