-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shut off MD module upgrades after 7.4 EOL #1084
Conversation
src/DependencyManagement/BackgroundDependencySnapshotMaintainer.cs
Outdated
Show resolved
Hide resolved
- Move ShouldEnableManagedDpendencyUpgrades logic to dedicated function - Move check to InstallAndPurgeSnapshots for long-running workers - Adjust tests to mock ShouldEnableManagedDpendencyUpgrades correctly
@@ -16,6 +16,8 @@ internal static class WorkerEnvironment | |||
private const string ContainerName = "CONTAINER_NAME"; | |||
private const string LegionServiceHost = "LEGION_SERVICE_HOST"; | |||
|
|||
private static readonly DateTime PowerShellSDKDeprecationDate = new DateTime(2026, 11, 10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to remember to keep updating this in the future. Perhaps we should add a reminder item to https://github.com/Azure/azure-functions-powershell-worker/blob/dev/upgrade_ps_sdk_instructions.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added create_new_worker_instructions.md to document steps that must be taken when updating to a new PS 7 minor version (like 7.6).
This file includes a note to update the Managed Dependencies shutoff date. It is likely we will find many new checklist items for this file as we start the 7.6 worker next year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Managed dependencies shutoff date must be updated
* Shut off MD module upgrades after 7.4 EOL * Add instructions for new PowerShell versions
* Backport of "Shut off MD module upgrades after 7.2 EOL" (#1084) * 7.2 specific changes
Will need to be added as part of documentation work for #943
Backport to 7.2 required, will link to that PR once this one is merged and rebased
Pull request checklist
release_notes.md