Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shut off MD module upgrades after 7.4 EOL #1084

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

andystaples
Copy link
Contributor

@andystaples andystaples commented Jul 11, 2024

Will need to be added as part of documentation work for #943
Backport to 7.2 required, will link to that PR once this one is merged and rebased

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@andystaples andystaples requested a review from AnatoliB July 11, 2024 21:55
- Move ShouldEnableManagedDpendencyUpgrades logic to dedicated function
- Move check to InstallAndPurgeSnapshots for long-running workers
- Adjust tests to mock ShouldEnableManagedDpendencyUpgrades correctly
@@ -16,6 +16,8 @@ internal static class WorkerEnvironment
private const string ContainerName = "CONTAINER_NAME";
private const string LegionServiceHost = "LEGION_SERVICE_HOST";

private static readonly DateTime PowerShellSDKDeprecationDate = new DateTime(2026, 11, 10);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to remember to keep updating this in the future. Perhaps we should add a reminder item to https://github.com/Azure/azure-functions-powershell-worker/blob/dev/upgrade_ps_sdk_instructions.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added create_new_worker_instructions.md to document steps that must be taken when updating to a new PS 7 minor version (like 7.6).
This file includes a note to update the Managed Dependencies shutoff date. It is likely we will find many new checklist items for this file as we start the 7.6 worker next year.

Copy link
Contributor

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Managed dependencies shutoff date must be updated
@andystaples andystaples merged commit acb5e60 into dev Sep 25, 2024
5 checks passed
@andystaples andystaples deleted the andystaples/add-EOL-date-MD-logic branch September 25, 2024 21:27
andystaples added a commit that referenced this pull request Sep 25, 2024
* Shut off MD module upgrades after 7.4 EOL
* Add instructions for new PowerShell versions
andystaples added a commit that referenced this pull request Oct 1, 2024
* Backport of "Shut off MD module upgrades after 7.2 EOL" (#1084)
* 7.2 specific changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants