Upgrade 1.5.2 and improve debugging #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsuyoshiUshio
changed the title
fbeltrao
previously approved these changes
Oct 20, 2020
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Config/KafkaOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Listeners/KafkaListener.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Output/KafkaProducerFactory.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Trigger/SingleItemFunctionExecutor.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Trigger/MultipleItemFunctionExecutor.cs
Outdated
Show resolved
Hide resolved
|
I upgrade the Confluent.Kafka library to 1.5.2 |
TsuyoshiUshio
changed the title
fbeltrao
previously approved these changes
Oct 21, 2020
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Output/KafkaProducerFactory.cs
Outdated
Show resolved
Hide resolved
fbeltrao
reviewed
Oct 21, 2020
amotl
reviewed
Oct 21, 2020
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Config/KafkaOptions.cs
Outdated
Show resolved
Hide resolved
…metadata.refresh.interval.ms
|
I update this PR according to the #187 |
amamounelsayed
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
Upgrade Confluent Kafka for avoiding limitation for Azure about the log-lived TCP Connection
The reason of the default settings, refer to this issue
Add Log to detect which FunctionExecutor do they use?
For the log of FunctionExecutor, I'd like to know if a user uses Single or Multiple Function Executor for diagnosing an issue.
If there is a better place, please let me know.
Redirect the Log of Libkafka native library
Currently, the Libkafka message is showed up standard output, that means there is no way to fetch it from Application Insights or other logging system.
Debug option enables librdkafka logging. https://github.com/edenhill/librdkafka
Fix
#185
#187