Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor build number for releases #780

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Refactor build number for releases #780

merged 1 commit into from
Aug 2, 2024

Conversation

kamperiadis
Copy link
Collaborator

Issue describing the changes in this PR

Currently, we rely on tags for our release process. However, instead, we can just rely on release branches.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@ahmedmuhsin ahmedmuhsin self-requested a review August 2, 2024 20:14
ahmedmuhsin
ahmedmuhsin approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@ahmedmuhsin ahmedmuhsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamperiadis kamperiadis merged commit 1db515f into dev Aug 2, 2024
4 checks passed
@kamperiadis kamperiadis deleted the kamperiadis/release branch August 2, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedmuhsin ahmedmuhsin ahmedmuhsin approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg anirudhgarg is a code owner

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio TsuyoshiUshio is a code owner

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed amamounelsayed is a code owner

@kaibocai kaibocai Awaiting requested review from kaibocai kaibocai is a code owner

@shreyas-gopalakrishna shreyas-gopalakrishna Awaiting requested review from shreyas-gopalakrishna shreyas-gopalakrishna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamperiadis @ahmedmuhsin