Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to fall back to old command line args if new args are missing #728

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Updated to fall back to old command line args if new args are missing #728

merged 1 commit into from
Sep 15, 2023

Conversation

shreyas-gopalakrishna
Copy link
Member

Updated to fall back to old command line args if new args are missing

resolves #724

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

kaibocai
kaibocai approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@kaibocai kaibocai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyas-gopalakrishna shreyas-gopalakrishna merged commit edd3c4c into dev Sep 15, 2023
10 checks passed
@shreyas-gopalakrishna shreyas-gopalakrishna deleted the shreyasg/old-commandline-args branch September 15, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaibocai kaibocai kaibocai approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg anirudhgarg is a code owner

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio TsuyoshiUshio is a code owner

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed amamounelsayed is a code owner

@kamperiadis kamperiadis Awaiting requested review from kamperiadis kamperiadis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update java language worker to support handling new command line arguments with functions- prefix
2 participants
@shreyas-gopalakrishna @kaibocai