Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Thread context classloder for entire middleware chain #717

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Set Thread context classloder for entire middleware chain #717

merged 3 commits into from
Sep 27, 2023

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Jun 23, 2023 •
edited
Loading

Issue describing the changes in this PR

This PR contributes to support customized Data Converter in https://github.com/microsoft/durabletask-java. Related issue: microsoft/durabletask-java#134

  1. Set thread context classloader to the one we provide to customer for the entire middleware chain so that all middleware in the chain have same thread context classloader and thus have access to customer classes and resources.
  2. With above change I am able to unify the executor for java11 and java8, so removed duplicate/unnecessary classes.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kaibocai kaibocai mentioned this pull request Jun 23, 2023
Draft
4 tasks
@kaibocai kaibocai marked this pull request as ready for review July 10, 2023 13:25
kamperiadis
kamperiadis approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@kamperiadis kamperiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaibocai kaibocai merged commit 5315874 into dev Sep 27, 2023
1 check passed
@kaibocai kaibocai deleted the kaibocai/df-dataconventer branch September 27, 2023 15:37
ahmedmuhsin added a commit that referenced this pull request Aug 2, 2024
@ahmedmuhsin
Revert "Set Thread context classloder for entire middleware chain (#717…
c1aae92 
…)"

This reverts commit 5315874.
ahmedmuhsin added a commit that referenced this pull request Aug 2, 2024
@ahmedmuhsin
Revert "Set Thread context classloder for entire middleware chain (#717…
b0bbee7 
…)"

This reverts commit 5315874.
ahmedmuhsin added a commit that referenced this pull request Aug 7, 2024
@ahmedmuhsin
Revert "Set Thread context classloder for entire middleware chain (#717…
c4aa165 
…)"

This reverts commit 5315874.
kamperiadis pushed a commit that referenced this pull request Aug 7, 2024
@ahmedmuhsin
Revert "Set Thread context classloder for entire middleware chain (#717…
74bbe0f 
…)" (#778)

This reverts commit 5315874.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamperiadis kamperiadis kamperiadis approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg anirudhgarg is a code owner

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio TsuyoshiUshio is a code owner

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed amamounelsayed is a code owner

@shreyas-gopalakrishna shreyas-gopalakrishna Awaiting requested review from shreyas-gopalakrishna shreyas-gopalakrishna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaibocai @kamperiadis