Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix durable return type void issue #711

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Fix durable return type void issue #711

merged 2 commits into from
Apr 14, 2023

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Apr 6, 2023

Issue describing the changes in this PR

resolves microsoft/durabletask-java#126

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

For function annotated with @HasImplicitOutput, we should allow it to send back data even function's return type is void
Reference to microsoft/durabletask-java#126

@kaibocai kaibocai mentioned this pull request Apr 6, 2023
Closed
shreyas-gopalakrishna
shreyas-gopalakrishna approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@shreyas-gopalakrishna shreyas-gopalakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kamperiadis
kamperiadis approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@kamperiadis kamperiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shreyas-gopalakrishna shreyas-gopalakrishna merged commit 2bc845a into dev Apr 14, 2023
@shreyas-gopalakrishna shreyas-gopalakrishna deleted the kaibocai/durable-issue126 branch April 14, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-gopalakrishna shreyas-gopalakrishna shreyas-gopalakrishna approved these changes

@kamperiadis kamperiadis kamperiadis approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg anirudhgarg is a code owner

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio TsuyoshiUshio is a code owner

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed amamounelsayed is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orchestrator functions failing if not returning anything
3 participants
@kaibocai @shreyas-gopalakrishna @kamperiadis