Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dependecy injection examples with Gooogle Juice and Dagger2 #698

Merged
merged 1 commit into from
Feb 10, 2023
Merged

add dependecy injection examples with Gooogle Juice and Dagger2 #698

merged 1 commit into from
Feb 10, 2023

Conversation

kaibocai
Copy link
Member

Issue describing the changes in this PR

add dependecy injection examples with Gooogle Juice and Dagger2

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR -- once document is ready will link it here.
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

kamperiadis
kamperiadis approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@kamperiadis kamperiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaibocai kaibocai merged commit 385d93a into dev Feb 10, 2023
@kaibocai kaibocai deleted the kaibocai/di-samples branch February 10, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamperiadis kamperiadis kamperiadis approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg anirudhgarg is a code owner

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio TsuyoshiUshio is a code owner

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed amamounelsayed is a code owner

@shreyas-gopalakrishna shreyas-gopalakrishna Awaiting requested review from shreyas-gopalakrishna shreyas-gopalakrishna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaibocai @kamperiadis