Setting FunctionDirectory and FunctionName on context. Refactoring directory resolution #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2017
Closed
mathewc
reviewed
May 1, 2017
| @@ -388,6 +389,8 @@ protected override void OnScriptFileChanged(object sender, FileSystemEventArgs e | |||
| var context = new Dictionary<string, object>() | |||
| { | |||
| { "invocationId", invocationContext.ExecutionContext.InvocationId }, | |||
| { "functionDirectory", invocationContext.ExecutionContext.FunctionDirectory }, | |||
There was a problem hiding this comment.
I wonder if we shouldn't add a new 'executionContext' member here that includes all 3 properties. We can leave the invocationId as is for back compat, but going forward it'd be good to have all the properties in a single object I think.
|
One small suggestion, otherwise looks good :) |
mathewc
approved these changes
May 1, 2017
directory resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #803