Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run benchmarking in dedicated agents (application and load) #10773

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Jan 28, 2025

With this change, the application and load generators run on separate agents. To share the application agent's IP address with the load generator agent, we use Azure Table Storage. Job output variables are not suitable as they become available only after the job finishes, whereas we need the job (agent) to remain running.

Sample pipeline run:

  1. https://azfunc.visualstudio.com/internal/_build/results?buildId=199693&view=results

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju requested a review from a team as a code owner January 28, 2025 18:01
@jviau jviau self-requested a review January 29, 2025 16:59
@kshyju kshyju force-pushed the shkr/vanilla_agents branch from 91663f9 to 7a899c3 Compare January 29, 2025 18:09
@kshyju kshyju merged commit cfa63f6 into dev Jan 29, 2025
9 checks passed
@kshyju kshyju deleted the shkr/vanilla_agents branch January 29, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants