Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused/obsolete Controller code #10748

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Removing unused/obsolete Controller code #10748

merged 1 commit into from
Jan 16, 2025

Conversation

mathewc
Copy link
Member

@mathewc mathewc commented Jan 15, 2025 •
edited
Loading

The API provided by this controller is no longer used, and known clients have moved away from its use long ago.

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@mathewc mathewc requested a review from a team as a code owner January 15, 2025 20:14
@mathewc mathewc requested review from fabiocav and jviau January 15, 2025 20:15
@mathewc mathewc merged commit 4dea997 into dev Jan 16, 2025
9 checks passed
@mathewc mathewc deleted the controller-cleanup branch January 16, 2025 01:26
mathewc added a commit that referenced this pull request Jan 16, 2025
@mathewc
Removing unused/obsolete Controller code (#10748)
36d819d
@mathewc mathewc mentioned this pull request Jan 16, 2025
Merged
mathewc added a commit that referenced this pull request Jan 16, 2025
@mathewc
Removing unused/obsolete Controller code (#10748) (#10749)
61e77d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviau jviau jviau approved these changes

@surgupta-msft surgupta-msft surgupta-msft approved these changes

@fabiocav fabiocav Awaiting requested review from fabiocav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathewc @jviau @surgupta-msft