Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating RetryProxyHandler strategy and retry counts #10566

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

fabiocav
Copy link
Member

@fabiocav fabiocav commented Oct 24, 2024

This PR improves the logic in the RetryProxyHandler to accommodate longer worker listener initialization times and address sandbox related issues on Windows consumption.

The new logic uses an exponential strategy, with a cap of 250ms, with a maximum iteration count of 10, allowing for 2100ms of startup time, which based on telemetry data, should be sufficient address the issues we're seeing.

I want to revisit this to make the handler parameters configurable, but this will come in a future iteration.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@fabiocav fabiocav requested a review from a team as a code owner October 24, 2024 09:03
@fabiocav fabiocav force-pushed the fabiocav/retryincrease branch from 98ad7e6 to 031831c Compare October 24, 2024 09:06
@fabiocav fabiocav merged commit 945efe1 into dev Oct 24, 2024
10 checks passed
@fabiocav fabiocav deleted the fabiocav/retryincrease branch October 24, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants