Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata provider timeout host config #10526

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Oct 15, 2024

Issue describing the changes in this PR

resolves #10529

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR: TODO:// Update host.json spec
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Adding a metadata provider timeout setting to the host.config to make this value configurable. For logic apps, we will not have a timeout limit.

@liliankasem liliankasem force-pushed the liliankasem/provider-timeout-config branch from ceacb74 to e673298 Compare October 15, 2024 20:45
@liliankasem liliankasem changed the title Add metadata provider timeout environment variable for configuration Add metadata provider timeout host config Oct 15, 2024
@liliankasem liliankasem marked this pull request as ready for review October 15, 2024 23:55
@liliankasem liliankasem requested a review from a team as a code owner October 15, 2024 23:55
@fabiocav
Copy link
Member

Approved... the tests seem to be unhappy with the string change :). Good change, but no good deed goes unpunished.

release_notes.md Outdated Show resolved Hide resolved
@liliankasem liliankasem force-pushed the liliankasem/provider-timeout-config branch from 92b8666 to 6dec500 Compare October 17, 2024 22:46
@liliankasem liliankasem merged commit a61ce6c into dev Oct 18, 2024
10 checks passed
@liliankasem liliankasem deleted the liliankasem/provider-timeout-config branch October 18, 2024 16:14
Francisco-Gamino added a commit that referenced this pull request Oct 30, 2024
Co-authored-by: Lilian Kasem <likasem@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make metadata provider timeout configurable
4 participants