Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.x]Update Middleware package #10492

Closed
wants to merge 3 commits into from
Closed

Conversation

pragnagopa
Copy link
Member

Issue describing the changes in this PR

Back port #10490

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@pragnagopa pragnagopa changed the title Update Middleware package [v3.x]Update Middleware package Sep 25, 2024
@pragnagopa
Copy link
Member Author

pragnagopa commented Sep 25, 2024

@fabiocav - need help with this PR - from failure logs - https://azfunc.visualstudio.com/public/_build/results?buildId=182319&view=logs&j=d3097984-58ae-595d-5abd-14a5c1707c21&t=9f63de88-fd7b-5bde-e456-e2fce12f3a74

Package is not found? does v3.x branch need an update to the app services nuget feed?

D:\a\_work\1\s\src\WebJobs.Script.WebHost\WebJobs.Script.WebHost.csproj : error NU1102: Unable to find package Microsoft.Azure.AppService.Middleware.Functions with version (>= 1.5.5) [D:\a\_work\1\s\test\WebJobs.Script.Tests\WebJobs.Script.Tests.csproj]
D:\a\_work\1\s\src\WebJobs.Script.WebHost\WebJobs.Script.WebHost.csproj : error NU1102:   - Found 2 version(s) in AzureFunctionsTempStaging [ Nearest version: 1.5.1 ] [D:\a\_work\1\s\test\WebJobs.Script.Tests\WebJobs.Script.Tests.csproj]
D:\a\_work\1\s\src\WebJobs.Script.WebHost\WebJobs.Script.WebHost.csproj : error NU1102:   - Found 0 version(s) in nuget.org [D:\a\_work\1\s\test\WebJobs.Script.Tests\WebJobs.Script.Tests.csproj]
D:\a\_work\1\s\src\WebJobs.Script.WebHost\WebJobs.Script.WebHost.csproj : error NU1102:   - Found 0 version(s) in azure-appservice-test [D:\a\_work\1\s\test\WebJobs.Script.Tests\WebJobs.Script.Tests.csproj]
D:\a\_work\1\s\src\WebJobs.Script.WebHost\WebJobs.Script.WebHost.csproj : error NU1102:   - Found 0 version(s) in AzureFunctionsPreRelease [D:\a\_work\1\s\test\WebJobs.Script.Tests\WebJobs.Script.Tests.csproj]
D:\a\_work\1\s\src\WebJobs.Script.WebHost\WebJobs.Script.WebHost.csproj : error NU1102:   - Found 0 version(s) in AzureFunctionsRelease [D:\a\_work\1\s\test\WebJobs.Script.Tests\WebJobs.Script.Tests.csproj]

[Update - error was misleading. Updated pkg references in test project]

Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is introducing the following dependency changes:

Changed:
    - Microsoft.Extensions.Configuration.Abstractions.dll: 3.1.9.0/3.100.920.47302 -> 5.0.0.0/5.0.20.51904
    - Microsoft.Extensions.Configuration.dll: 3.1.9.0/3.100.920.47302 -> 5.0.0.0/5.0.20.51904
    - Microsoft.Extensions.DependencyInjection.Abstractions.dll: 3.1.9.0/3.100.920.47302 -> 5.0.0.0/5.0.20.51904
    - Microsoft.Extensions.DependencyInjection.dll: 3.1.9.0/3.100.920.47302 -> 5.0.0.0/5.0.20.51904
    - Microsoft.Extensions.Logging.Abstractions.dll: 3.1.9.0/3.100.920.47302 -> 5.0.0.0/5.0.20.51904
    - Microsoft.Extensions.Logging.dll: 3.1.9.0/3.100.920.47302 -> 5.0.0.0/5.0.20.51904
    - Microsoft.Extensions.Options.dll: 3.1.9.0/3.100.920.47302 -> 5.0.0.0/5.0.20.51904
    - Microsoft.Extensions.Primitives.dll: 3.1.9.0/3.100.920.47302 -> 5.0.0.0/5.0.20.51904
    - Microsoft.IdentityModel.JsonWebTokens.dll: 5.5.0.0/5.5.0.60624 -> 6.32.0.0/6.32.0.40712
    - Microsoft.IdentityModel.Logging.dll: 5.5.0.0/5.5.0.60624 -> 6.32.0.0/6.32.0.40712
    - Microsoft.IdentityModel.Protocols.dll: 5.5.0.0/5.5.0.60624 -> 6.32.0.0/6.32.0.40712
    - Microsoft.IdentityModel.Protocols.OpenIdConnect.dll: 5.5.0.0/5.5.0.60624 -> 6.32.0.0/6.32.0.40712
    - Microsoft.IdentityModel.Tokens.dll: 5.5.0.0/5.5.0.60624 -> 6.32.0.0/6.32.0.40712
    - Newtonsoft.Json.dll: 12.0.0.0/12.0.3.23909 -> 13.0.0.0/13.0.1.25517
    - System.IdentityModel.Tokens.Jwt.dll: 5.5.0.0/5.5.0.60624 -> 6.32.0.0/6.32.0.40712

  Removed:
    - Microsoft.Extensions.Configuration.Binder.dll: 3.1.9.0/3.100.920.47302

  Added:
    - Microsoft.Extensions.Caching.Abstractions.dll: 5.0.0.0/5.0.20.51904
    - Microsoft.Extensions.Caching.Memory.dll: 5.0.0.0/5.0.20.51904
    - Microsoft.IdentityModel.Abstractions.dll: 6.32.0.0/6.32.0.40712
    - Microsoft.IdentityModel.Validators.dll: 6.32.0.0/6.32.0.40712
    - System.Text.Json.dll: 4.0.1.2/4.700.20.21406

Some of those are across major versions, so we can't safely bring them.

@@ -8,6 +8,7 @@
<add key="Microsoft.Azure.Functions.PowerShellWorker" value="https://azfunc.pkgs.visualstudio.com/e6a70c92-4128-439f-8012-382fe78d6396/_packaging/Microsoft.Azure.Functions.PowerShellWorker/nuget/v3/index.json" />
<add key="AzureFunctionsRelease" value="https://azfunc.pkgs.visualstudio.com/e6a70c92-4128-439f-8012-382fe78d6396/_packaging/AzureFunctionsRelease/nuget/v3/index.json" />
<add key="AzureFunctionsPreRelease" value="https://azfunc.pkgs.visualstudio.com/e6a70c92-4128-439f-8012-382fe78d6396/_packaging/AzureFunctionsPreRelease/nuget/v3/index.json" />
<add key="AzureFunctions@internalrelease" value="https://azfunc.pkgs.visualstudio.com/e6a70c92-4128-439f-8012-382fe78d6396/_packaging/AzureFunctions%40internalrelease/nuget/v3/index.json" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: formatting.

Copy link
Contributor

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants