Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all non host startup logs for v3.x #10399

Merged
merged 9 commits into from
Aug 16, 2024
Merged

Conversation

surgupta-msft
Copy link
Contributor

@surgupta-msft surgupta-msft commented Aug 13, 2024

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@surgupta-msft surgupta-msft marked this pull request as ready for review August 14, 2024 18:58
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we disabling non startup logs for all categories or just Informational and below? For example, an app crashes and tries to log error log entry (Level==2), this change will prevent that from being logged. Is that the desired behavior?

src/WebJobs.Script/ScriptConstants.cs Outdated Show resolved Hide resolved
src/WebJobs.Script/ScriptConstants.cs Outdated Show resolved Hide resolved
@surgupta-msft surgupta-msft requested review from fabiocav and removed request for fabiocav August 16, 2024 05:29
@fabiocav fabiocav merged commit 8335eb4 into v3.x Aug 16, 2024
10 checks passed
@fabiocav fabiocav deleted the surgupta/filter-logs-v3-2 branch August 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants