fix: entity id should compare based on name and key #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2024
Merged
davidmrdavid
approved these changes
Sep 9, 2024
|
Thanks for your contribution @LeonardHd. This looks great but in order to merge, we need you to update your branch with the latest. Can you please do that? Thanks! |
LeonardHd
force-pushed
the
leonardhd/entity-id-equality
branch
from
6c2cd76 to
c422feb
Compare
|
@davidmrdavid rebased to latest |
|
This is great, merged. Thank you @LeonardHd for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a issue #521 where unit tests involving the [
EntityId] class were failing due to the lack of an equality check based onkeyandnameTo resolve this, we have implemented the__eq__operator in theEntityIdclass. This enhancement ensures that instances ofEntityIdare compared correctly, improving the reliability and accuracy of unit tests.Changes:
__eq__operator in the EntityIdclass to compare instances based onkeyandname`.This change will make unit tests involving
EntityIdpass as expected, providing a better user experience for developers.