Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Newtonsoft to System.Text.Json #91

Merged
merged 16 commits into from
Apr 6, 2023
Merged

Migrate from Newtonsoft to System.Text.Json #91

merged 16 commits into from
Apr 6, 2023

Conversation

shubham1172
Copy link
Member

@shubham1172 shubham1172 commented Apr 3, 2023 •
edited by ASHIQUEMD
Loading

Co-Authored by: @ASHIQUEMD (Generic Converter for State Binding from #90)

This PR updates the codebase to use STJ (System.Text.Json) instead of Newtonsoft. There are a few updates

  • Instead of JToken, all internal classes use JsonElement (STJ) for storing data, along with a custom JsonElementConverter that converts with UnsafeRelaxedJsonEscaping.
  • The APIs support both STJ and NS as method parameters - this is because the underlying functions framework does not support expressions using STJ
  • The method return type and all internals are STJ based only
  • Update CloudEvents to 2.6.0
  • Add Generic Converter base class for converting JsonElement to T types
  • Add new tests

Closes #9

shubham1172 and others added 13 commits April 3, 2023 13:31
@shubham1172
Move bindings to STJ
a4fe304 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Checkpoint
e89f42a 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Checkpoint
b9cf6ac 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Invoke fix
3e1df09 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Fix a crazy bindings bug
bb6f4f4 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Fix binding test
0ea8f63 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Fix state tests
01eea01 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Everything works (for now)
9beb1f4 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Add JObject support to secret
517a122 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 @ASHIQUEMD
Add generic binding converters
26f9a2d 
Co-authored-by: MD Ashique <noorani.ashique5@gmail.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Fix test
f6f3d25 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Refactor
4d305e4 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Refactor
1721d83 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 changed the title [WIP] Migrate from Newtonsoft to System.Text.Json Migrate from Newtonsoft to System.Text.Json Apr 5, 2023
@shubham1172 shubham1172 marked this pull request as ready for review April 5, 2023 12:07
@ASHIQUEMD ASHIQUEMD self-requested a review April 5, 2023 16:23
ASHIQUEMD
ASHIQUEMD requested changes Apr 5, 2023
View reviewed changes
src/Microsoft.Azure.WebJobs.Extension.Dapr/Bindings/Converters/DaprSecretConverter.cs Outdated Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extension.Dapr/Bindings/Converters/DaprGenericsConverterBase.cs Outdated Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extension.Dapr/Bindings/Converters/DaprStateConverter.cs Outdated Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extension.Dapr/Bindings/DaprStateRecord.cs Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extension.Dapr/Bindings/InvokeMethodParameters.cs Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extension.Dapr/DaprExtensionConfigProvider.cs Show resolved Hide resolved
...crosoft.Azure.WebJobs.Extension.Dapr/Triggers/DaprServiceInvocationTriggerBindingProvider.cs Outdated Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extension.Dapr/Triggers/DaprTopicTriggerBindingProvider.cs Outdated Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extension.Dapr/Utils/JsonElementConverter.cs Outdated Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extension.Dapr/Utils/JsonUtils.cs Outdated Show resolved Hide resolved
@shubham1172
Update project name
83f1aad 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Address comments
e6b641d 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Better error handling
8777f40 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
ASHIQUEMD
ASHIQUEMD approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@ASHIQUEMD ASHIQUEMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham1172 shubham1172 merged commit 1f8e283 into Azure:master Apr 6, 2023
ASHIQUEMD added a commit to ASHIQUEMD/azure-functions-dapr-extension that referenced this pull request Apr 6, 2023
@ASHIQUEMD
Merge pull request #1 from Azure/master
511e662 
Migrate from Newtonsoft to System.Text.Json (Azure#91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASHIQUEMD ASHIQUEMD ASHIQUEMD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use System.Text.Json instead of Newtonsoft
2 participants
@shubham1172 @ASHIQUEMD