Flex Deployment Changes #3625
Flex Deployment Changes #3625
Conversation
| string functionAppString = JsonConvert.SerializeObject(functionApp); | ||
|
|
||
| url = new Uri($"{managementURL}{site.SiteId}?api-version={ArmUriTemplates.FlexApiVersion}"); | ||
| await ArmHttpAsyncForFlex(new HttpMethod("PATCH"), url, accessToken, functionApp); |
There was a problem hiding this comment.
AFAIK, we currently can't do a PATCH request to update attributes, we'll need to do a PUT.
There was a problem hiding this comment.
Thanks @kamperiadis! Can you please share the recommended API. I got it from my local AZ CLI copy which was using Patch. Interestingly, it is actually working in beta :).
There was a problem hiding this comment.
I just confirmed with David today - we did not do any implementation changes for PATCH, which might be missing things like blocking unsupported configs in the Site object. I would not suggest using PATCH. Instead, we should be doing a GET call to the function app and then do a PUT request with that same function app object but with the updated values.
Not sure what Az CLI copy you have but for flex specifically, the Az CLI makes PUT calls when updating the runtime.
There was a problem hiding this comment.
Changed it to us PUT instead of PATCH.
| string functionAppString = JsonConvert.SerializeObject(functionApp); | ||
|
|
||
| url = new Uri($"{managementURL}{site.SiteId}?api-version={ArmUriTemplates.FlexApiVersion}"); | ||
| await ArmHttpAsyncForFlex(new HttpMethod("PATCH"), url, accessToken, functionApp); |
There was a problem hiding this comment.
I just confirmed with David today - we did not do any implementation changes for PATCH, which might be missing things like blocking unsupported configs in the Site object. I would not suggest using PATCH. Instead, we should be doing a GET call to the function app and then do a PUT request with that same function app object but with the updated values.
Not sure what Az CLI copy you have but for flex specifically, the Az CLI makes PUT calls when updating the runtime.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist