Alter key generation logic V4 #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpeng36
requested review from
vrdmr,
Francisco-Gamino,
amamounelsayed,
alrod and
AnatoliB
as code owners
mathewc
reviewed
May 2, 2022
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk" InitialTargets="ExcludeWorkersFromReadyToRun"> | |||
| <Project Sdk="Microsoft.NET.Sdk" InitialTargets="ExcludeWorkersFromReadyToRun"> | |||
There was a problem hiding this comment.
Assuming the reason there are no changes other than whitespace to this file is because you reverted the WebHost package update? Might as well update this PR to reference your updated preview build version you're testing with for clarity, and as you said, once you move to the actual 4.3.x version with the required changes
|
Changes look good. Just need to update the PR to reference the final WebHost version |
michaelpeng36
force-pushed
the
michaelpeng/keygen-v4
branch
from
d652f77
to
becca87
Compare
ejizba
approved these changes
May 9, 2022
mathewc
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Resolves #2944 for Core Tools V4. This PR should not be merged until the WebHost and worker versions have been updated for the next Core Tools V4 release corresponding to Host version 4.3.1 or later. This change is to be backported to
v3.x.Pull request checklist
v3.x