Fix an Interop issue: Amqp body section can be AmqpValue or AmqpSequence #66

SreeramGarlapati · 2017-03-02T05:07:39Z

support interop with 2 other body types - amqp-value & amqp-sequence
receivedEvent.getBody() should throw and communicate - in case of interop issues

fix for issue: #59

…nce (#3) * support interop with 2 other body types - amqp-value & amqp-sequence * receivedEvent.getBody() should throw and communicate - in case of interop issues

msftclas · 2017-03-02T05:07:43Z

@SreeramGarlapati,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

xinchen10 · 2017-03-03T02:18:57Z

azure-eventhubs/src/main/java/com/microsoft/azure/eventhubs/EventData.java

+                        receiveProperties.put(AmqpConstants.AMQP_SEQUENCE, ((AmqpSequence) bodySection).getValue());
+                }
+                else {
+                    this.bodyType = Data.class;


Do you need this? It is set to default in the ctor. #Resolved

This ctor doesn't invoke the default ctor

In reply to: 104077202 [](ancestors = 104077202)

xinchen10 · 2017-03-03T02:20:16Z

azure-eventhubs/src/main/java/com/microsoft/azure/eventhubs/IllegalEventDataBodyException.java

+
+import com.microsoft.azure.servicebus.amqp.AmqpConstants;
+
+public class IllegalEventDataBodyException extends RuntimeException {


UnexpectedEventDataBodyException?

xinchen10 · 2017-03-03T02:22:03Z

azure-eventhubs/src/main/java/com/microsoft/azure/eventhubs/IllegalEventDataBodyException.java

+            ? String.format("AmqpMessage Body Section will be available in %s.getBody() only if it is of type: %s. If AmqpMessage is sent with any other Body type - it will be added to %s.getSystemProperties(). Use thisException.getSystemPropertyName() method to find this value in %s.getSystemProperties()",
+                    EventData.class, Data.class, EventData.class, EventData.class)
+            : "AmqpMessage Body Section cannot be mapped to any EventData section.");
+        this.bodySection = actualBodySection;


There are no other body types. If it is not Data, it must be either Value or Sequence. This should be ensured by Proton-J.

While as per the SPEC this is correct - this happened a while back: -we saw ApplicationProperties as part of Data section (I am still investigating how this was possible):

17/02/02 20:34:20 ERROR ReceiverTracker: Deregistered receiver for stream 19: Restarting receiver with delay 2000ms: Error handling message, restarting receiver for partition 19 - java.util.concurrent.ExecutionException: java.lang.ClassCastException: org.apache.qpid.proton.amqp.messaging.ApplicationProperties cannot be cast to org.apache.qpid.proton.amqp.messaging.Data
at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895)
at org.apache.spark.streaming.eventhubs.EventHubsClientWrapper.receive(EventHubsClientWrapper.scala:158)
at org.apache.spark.streaming.eventhubs.EventHubsReceiver$EventHubsMessageHandler.run(EventHubsReceiver.scala:117)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.ClassCastException: org.apache.qpid.proton.amqp.messaging.ApplicationProperties cannot be cast to org.apache.qpid.proton.amqp.messaging.Data
at com.microsoft.azure.eventhubs.EventData.(EventData.java:85)
at com.microsoft.azure.eventhubs.EventDataUtil.toEventDataCollection(EventDataUtil.java:46)
at com.microsoft.azure.eventhubs.PartitionReceiver$3.apply(PartitionReceiver.java:285)
at com.microsoft.azure.eventhubs.PartitionReceiver$3.apply(PartitionReceiver.java:281)
at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602)
at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:577)
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962)
at com.microsoft.azure.servicebus.MessageReceiver$4.onEvent(MessageReceiver.java:305)
at com.microsoft.azure.servicebus.amqp.DispatchHandler.onTimerTask(DispatchHandler.java:10)
at com.microsoft.azure.servicebus.amqp.ReactorDispatcher$ScheduleHandler.run(ReactorDispatcher.java:126)
at org.apache.qpid.proton.reactor.impl.SelectableImpl.readable(SelectableImpl.java:118)
at org.apache.qpid.proton.reactor.impl.IOHandler.handleQuiesced(IOHandler.java:61)
at org.apache.qpid.proton.reactor.impl.IOHandler.onUnhandled(IOHandler.java:381)
at org.apache.qpid.proton.engine.BaseHandler.onReactorQuiesced(BaseHandler.java:87)
at org.apache.qpid.proton.engine.BaseHandler.handle(BaseHandler.java:206)
at org.apache.qpid.proton.engine.impl.EventImpl.dispatch(EventImpl.java:108)
at org.apache.qpid.proton.reactor.impl.ReactorImpl.dispatch(ReactorImpl.java:309)
at org.apache.qpid.proton.reactor.impl.ReactorImpl.process(ReactorImpl.java:277)
at com.microsoft.azure.servicebus.MessagingFactory$RunReactor.run(MessagingFactory.java:340)
... 1 more

In reply to: 104077500 [](ancestors = 104077500)

…into sg.interop

…e-event-hubs-java into sg.interop

…Azure#66) * support interop with 2 other body types - amqp-value & amqp-sequence * receivedEvent.getBody() should throw and communicate - in case of interop issues * fix flaky CIT issues * Change exception name from Illegal to Unexpected * implement reSend path for other Body section types

* Fix Interop issue: Amqp body section can be AmqpValue or AmqpSequence (#66) * support interop with 2 other body types - amqp-value & amqp-sequence * receivedEvent.getBody() should throw and communicate - in case of interop issues * fix flaky CIT issues * Change exception name from Illegal to Unexpected * implement reSend path for other Body section types * update proton-j to latest (0.18.0) * handle interop amqpmessage body with value and sequence sections (#81) * partial changes * interop body method * remove getbody recommendation in javadoc * Remove array copy solution in getBytes() and fix javadoc * bump up the version of javaClient * fix javadoc

…#66) * support interop with 2 other body types - amqp-value & amqp-sequence * receivedEvent.getBody() should throw and communicate - in case of interop issues * fix flaky CIT issues * Change exception name from Illegal to Unexpected * implement reSend path for other Body section types

* Fix Interop issue: Amqp body section can be AmqpValue or AmqpSequence (#66) * support interop with 2 other body types - amqp-value & amqp-sequence * receivedEvent.getBody() should throw and communicate - in case of interop issues * fix flaky CIT issues * Change exception name from Illegal to Unexpected * implement reSend path for other Body section types * update proton-j to latest (0.18.0) * handle interop amqpmessage body with value and sequence sections (#81) * partial changes * interop body method * remove getbody recommendation in javadoc * Remove array copy solution in getBytes() and fix javadoc * bump up the version of javaClient * fix javadoc

Fix an Interop issue: Amqp body section can be AmqpValue or AmqpSeque…

98c638e

…nce (#3) * support interop with 2 other body types - amqp-value & amqp-sequence * receivedEvent.getBody() should throw and communicate - in case of interop issues

msftclas added the cla-not-required label Mar 2, 2017

SreeramGarlapati requested review from sjkwak, JamesBirdsall and xinchen10 and removed request for xinchen10 March 2, 2017 05:08

SreeramGarlapati mentioned this pull request Mar 2, 2017

ClassCastException when I consume a message #59

Closed

fix flaky CIT issues

d364a8e

SreeramGarlapati mentioned this pull request Mar 4, 2017

STORM-2371: New eventhub implementation apache/storm#1985

Closed

Merge branch 'dev' into sg.interop

6517f4c

SreeramGarlapati requested a review from xinchen10 March 7, 2017 19:42

xinchen10 reviewed Mar 7, 2017

View reviewed changes

Change exception name from Illegal to Unexpected

ab8c196

xinchen10 approved these changes Mar 7, 2017

View reviewed changes

SreeramGarlapati added 3 commits March 7, 2017 16:27

Merge branch 'dev' of https://github.com/Azure/azure-event-hubs-java …

0e9e945

…into sg.interop

Merge branch 'sg.interop' of https://github.com/SreeramGarlapati/azur…

ff730b9

…e-event-hubs-java into sg.interop

implement reSend path for other Body section types

d219f47

SreeramGarlapati merged commit 3bed922 into Azure:dev Mar 8, 2017

SreeramGarlapati deleted the sg.interop branch March 8, 2017 02:01

jtaubensee added this to the 0.13.0 milestone Mar 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix an Interop issue: Amqp body section can be AmqpValue or AmqpSequence #66

Fix an Interop issue: Amqp body section can be AmqpValue or AmqpSequence #66

SreeramGarlapati commented Mar 2, 2017

msftclas commented Mar 2, 2017

xinchen10 Mar 3, 2017 •

edited by SreeramGarlapati

Loading

SreeramGarlapati Mar 7, 2017

xinchen10 Mar 3, 2017

xinchen10 Mar 3, 2017

SreeramGarlapati Mar 7, 2017


		import com.microsoft.azure.servicebus.amqp.AmqpConstants;

		public class IllegalEventDataBodyException extends RuntimeException {

Fix an Interop issue: Amqp body section can be AmqpValue or AmqpSequence #66

Fix an Interop issue: Amqp body section can be AmqpValue or AmqpSequence #66

Conversation

SreeramGarlapati commented Mar 2, 2017

msftclas commented Mar 2, 2017

xinchen10 Mar 3, 2017 • edited by SreeramGarlapati Loading

Choose a reason for hiding this comment

SreeramGarlapati Mar 7, 2017

Choose a reason for hiding this comment

xinchen10 Mar 3, 2017

Choose a reason for hiding this comment

xinchen10 Mar 3, 2017

Choose a reason for hiding this comment

SreeramGarlapati Mar 7, 2017

Choose a reason for hiding this comment

xinchen10 Mar 3, 2017 •

edited by SreeramGarlapati

Loading