-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose: add command #4527
compose: add command #4527
Conversation
6f51f30
to
14cea96
Compare
14cea96
to
801d707
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very exciting to see this! Thanks for all the work over the past few weeks with the smaller PRs - this was pretty focused and easy for me to digest.
I think the thing I care most about this the promptCtx
type. Given how stuff shook out I wonder if we really want to be tying the context.Context
and *project.ProjectConfig
together like this. It doesn't seem like it makes the parameter list of methods that use it that much nicer, and I'll admit that I'm sort of always wary about combining the context.Context
with other stuff.
Added some comments about things that jumped out at me and tried to respond to Victor's.
I'll admit I didn't examine the diff generation logic in great detail yet.
Overall though this feels really good, great job here, @weikanglim!
801d707
to
55bab96
Compare
f094721
to
e9eea4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the promptOptions/context decoupling! Really excited to see what the larger world thinks of this! Great job, @weikanglim!
e9eea4e
to
b2d0702
Compare
b2d0702
to
1fd20c2
Compare
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
add
command that adds resource configuration toazure.yaml
.In this experience, users are able to proceed with running
provision
orup
after committing theazure.yaml
change.Contributes to #4397, https://github.com/Azure/azure-dev-pr/issues/1682