-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document drop handler and telemetry #2448
Conversation
The code looks great, but I have doubts about the cost/risk/benefit tradeoff of this change. Discoverability of the feature is terrible. Utility is marginal at best given that |
I'm playing catch up now that I'm back from vacation. Oh this is super cool! I think that this will definitely be helpful to some folks who really struggle with paths. I don't disagree with Karol re. discoverability but tbh, there are loads of valuable features in VS Code with poor discoverability (basically all VS Code settings 🙂) Can we instrument telemetry around this so we can monitor how often it's being used/triggered? |
Absolutely agreed. Especially since you have to hold Shift to even get the options to show when dropping. Not a common paradigm at all.
I thought of this more as a fun feature to show off in demos than to actually be seriously useful to end users. If it starts presenting itself as a maintenance problem, I wouldn't hesitate to drop it. |
Yes, and in fact I think I'll add some additional telemetry on the other language features as well. |
Yeah - makes sense to me. With telemetry, we can see if it's really a useful feature for folks to have/worth the maintenance. |
VSCode Extension Installation Instructions
|
@esweet431 as FYI for new feature + telemetry |
Related to #1389, adds a special new feature just for @savannahostrowski and @gkulin. Drag a folder into
azure.yaml
and hold Shift before releasing--it will automatically add a service to yourazure.yaml
file, with tab stops at the project language and host and enums to help select the right values in those places.This feature is admittedly pretty gimmicky but I thought it looked neat.