Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics: Adds startDate in Summary #3707

Merged
merged 8 commits into from
Feb 27, 2023
Merged

Diagnostics: Adds startDate in Summary #3707

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3cb0558
Merge pull request #1 from Azure/master
NimitS1 Jan 5, 2023
54accad
Merge branch 'master' of https://github.com/NimitS1/azure-cosmos-dotn…
NimitS1 Feb 13, 2023
674a08a
Adding start date
NimitS1 Feb 13, 2023
d0afa63
Updated trace files
NimitS1 Feb 13, 2023
c1937d1
Merge branch 'master' into master
ealsur Feb 16, 2023
b058432
Merge branch 'master' into master
ealsur Feb 21, 2023
3a68151
PR comment
NimitS1 Feb 25, 2023
58554e0
Committing missing tests
NimitS1 Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ public static void WriteTrace(

if (isRootTrace)
{
writer.WriteFieldName("start date");
writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.DateFormatString));
writer.WriteFieldName("start time");
writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.HourTimeFormatString));
}
Expand Down
1 change: 1 addition & 0 deletions Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ namespace Microsoft.Azure.Cosmos.Tracing
internal static partial class TraceWriter
{
internal static readonly string HourTimeFormatString = "HH:mm:ss:fff";
internal static readonly string DateFormatString = "yyyy-MM-dd";

private static class TraceTextWriter
{
Expand Down
1 change: 1 addition & 0 deletions ...Tests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "ExecuteAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down
11 changes: 11 additions & 0 deletions ...rTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BulkOperationsAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -218,6 +219,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -376,6 +378,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -534,6 +537,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -692,6 +696,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -850,6 +855,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -1008,6 +1014,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -1166,6 +1173,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -1324,6 +1332,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -1482,6 +1491,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -1796,6 +1806,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down
5 changes: 5 additions & 0 deletions ...latorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ChangeFeedAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -1124,6 +1125,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -1738,6 +1740,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -2340,6 +2343,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -2888,6 +2892,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down
2 changes: 2 additions & 0 deletions ...torTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.MiscellanousAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateDatabaseAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -154,6 +155,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateDatabaseAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down
6 changes: 6 additions & 0 deletions ...lineTest/TestBaseline/EndToEndTraceWriterBaselineTests.PointOperationsExceptionsAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -254,6 +255,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -514,6 +516,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -750,6 +753,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -1029,6 +1033,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -1267,6 +1272,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down
7 changes: 7 additions & 0 deletions ...s.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.QueryAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -753,6 +754,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -1356,6 +1358,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -1947,6 +1950,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -2577,6 +2581,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -3227,6 +3232,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -3827,6 +3833,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down
4 changes: 4 additions & 0 deletions ...mulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadFeedAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -691,6 +692,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -1256,6 +1258,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down Expand Up @@ -1809,6 +1812,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "Trace Forest",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"children": [
Expand Down
2 changes: 2 additions & 0 deletions ...mulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadManyAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "ReadManyItemsStreamAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -696,6 +697,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "ReadManyItemsAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down
4 changes: 4 additions & 0 deletions ...BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.StreamPointOperationsAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemStreamAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -130,6 +131,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "ReadItemStreamAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -227,6 +229,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "ReplaceItemStreamAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -319,6 +322,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "DeleteItemStreamAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down
4 changes: 4 additions & 0 deletions .../BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.TypedPointOperationsAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "CreateItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -151,6 +152,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "ReadItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -254,6 +256,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "ReplaceItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down Expand Up @@ -354,6 +357,7 @@
<Json><![CDATA[{
"Summary": {},
"name": "DeleteItemAsync",
"start date": "0001-01-01",
"start time": "00:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand Down
Loading