[Containerapp] az containerapp update: Fix issue for minReplicas in --yaml or --min-replicas is not set when the value is 0
#27948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Containerapp |
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yanzhudd,
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl and
jijohn14
Greedygre
commented
Nov 30, 2023
| resource_group, containerapp_name) | ||
| self.cmd(update_string, checks=[ | ||
| JMESPathCheck('name', containerapp_name), | ||
| JMESPathCheck('properties.configuration.registries[0].server', registry_server), | ||
| JMESPathCheck('properties.configuration.registries[0].username', registry_username), | ||
| JMESPathCheck('length(properties.configuration.secrets)', 1), | ||
| JMESPathCheck('properties.template.scale.minReplicas', '0'), | ||
| JMESPathCheck('properties.template.scale.minReplicas', '1'), |
There was a problem hiding this comment.
0 is the default value for min-replicas.
In the behind will update the --min-replicas to 0, we need to set the --min-replicas to other value first.
Greedygre
changed the title
az containerapp update: Fix issue for minReplicas in --yaml or --min-replicas is not set when the value is 0az containerapp update: Fix issue for minReplicas in --yaml or --min-replicas is not set when the value is 0
Greedygre
changed the title
az containerapp update: Fix issue for minReplicas in --yaml or --min-replicas is not set when the value is 0az containerapp update: Fix [issue](https://github.com/Azure/azure-cli-extensions/issues/5391) for minReplicas in --yaml or --min-replicas is not set when the value is 0
Greedygre
changed the title
az containerapp update: Fix [issue](https://github.com/Azure/azure-cli-extensions/issues/5391) for minReplicas in --yaml or --min-replicas is not set when the value is 0az containerapp update: Fix issue #https://github.com/Azure/azure-cli-extensions/issues/5391 for minReplicas in --yaml or --min-replicas is not set when the value is 0
Greedygre
changed the title
az containerapp update: Fix issue #https://github.com/Azure/azure-cli-extensions/issues/5391 for minReplicas in --yaml or --min-replicas is not set when the value is 0az containerapp update: Fix issue for minReplicas in --yaml or --min-replicas is not set when the value is 0
3 tasks
Juliehzl
reviewed
Nov 30, 2023
Juliehzl
approved these changes
Nov 30, 2023
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
approved these changes
Nov 30, 2023
albertofori
pushed a commit
to albertofori/azure-cli
that referenced
this pull request
Dec 14, 2023
… `--yaml` or `--min-replicas` is not set when the value is `0` (Azure#27948)
Greedygre
pushed a commit
to Greedygre/azure-cli
that referenced
this pull request
Jan 5, 2024
…licas in `--yaml` or `--min-replicas` is not set when the value is `0` (Azure#27948)" This reverts commit 1597b4f.
3 tasks
zhoxing-ms
pushed a commit
that referenced
this pull request
Jan 8, 2024
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp update --min-replicas --yamlFix issue:
Azure/azure-cli-extensions#5391
Fix bug for minReplicas in --yaml or --min-replicas is not set when the value is 0.
Description
Testing Guide
History Notes
[Containerapp]
az containerapp update: Fix issue for minReplicas in--yamlor--min-replicasis not set when the value is0[Containerapp]
az containerapp job update: Fix bug for minExecutions in--yamlis not set when the value is0This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.