[Core] Add the suggestion to fix an error from a command by using LLM #27801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kceiw
requested review from
jiasli,
evelyn-ys,
jsntcy,
kairu-ms,
zhoxing-ms,
calvinhzy and
necusjz
as code owners
|
Hi @kceiw, |
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Core |
This was referenced Nov 8, 2023
…nse from OpenAI. Need to engineer prompt better and fix formatting.
zhoxing-ms
reviewed
Nov 23, 2023
zhoxing-ms
reviewed
Nov 23, 2023
zhoxing-ms
reviewed
Nov 23, 2023
zhoxing-ms
reviewed
Nov 23, 2023
jiasli
reviewed
Nov 30, 2023
- The library knack's code is modified to pass the arguments to the function handle_exception. That's not correct. Revert that change. And we find a different way of getting the full command line when we handle the exception.
ReaNAiveD
reviewed
Dec 19, 2023
ReaNAiveD
reviewed
Dec 20, 2023
- This is needed when the function is called directly in the user code e.g. interative extension. - This is not used when the called is routed through knack.
|
@jiasli, @zhoxing-ms, @ReaNAiveD |
- We get the argument and its value by parsing the shell command that handles special characters in the argument value. We should also join the argument in the shell way that handles special characters.
zhoxing-ms
reviewed
Jan 11, 2024
Comment on lines
+19
to
+23
| _DEEPPROMPT_ENDPOINT = "<url>" | ||
| _DEEPPROMPT_APP = "<appid>" | ||
| _AAD_TENANT = "<tenant>" | ||
| _SCOPES = [f"{_DEEPPROMPT_APP}/.default"] | ||
| _TIMEOUT = 180 |
There was a problem hiding this comment.
As far as I know, Azure CLI previously requested another Aladdin service endpoint https://app.aladdin.microsoft.com/api/v1.0/suggestions. May I ask if Azure CLI can request a unified Aladdin endpoint , while the internal logic of the Aladdin service handles different situations? Perhaps this can reduce duplicate code and maintenance costs?
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
approved these changes
Jan 12, 2024
ReaNAiveD
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
This change is applied to the core of the azure cli, when a command runs into an error.
Description
When users run a command, they may run into various errors from syntax error to the error from Azure service. It may take some time research on those errors. Especially for the beginners, it may be more difficult for them to get the information to fix the error. In this PR, we're using the LLM to help with getting the fix to the error. We need to get the whole command line and the errors, then send it to the service, and then get the response and show that on the terminal.
Two separate configurations are used to control whether to enable the feature for interactive mode and the default CLI. These configurations can be set as follows:
Testing Guide
Start the interactive mode and then run some commands.
We need the change in the interactive mode code base to use this feature. The change in interactive mode is in this pull request Azure/azure-cli-extensions#6966
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.