[ARM] BREAKING CHANGE: az stack mg create: Enable mg scoped deployments for mg scoped stacks
#27709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔄AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-14)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
dantedallag
changed the title
dantedallag
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
dantedallag
changed the title
az stack mg create: Enabling mg scoped deployments for mg scoped stacks.
dantedallag
changed the title
az stack mg create: Enabling mg scoped deployments for mg scoped stacks.az stack mg create: Enable mg scoped deployments for mg scoped stacks.
dantedallag
changed the title
az stack mg create: Enable mg scoped deployments for mg scoped stacks.az stack mg create: Enable mg scoped deployments for mg scoped stacks
|
@zhoxing-ms Could you help us out with the job that is failing? Seems like an extension is failing to be loaded in and I am unsure if has been caused by my changes. |
|
Hi @zhoxing-ms and @yonzhan - friendly ping for review here. We are targeting the upcoming code complete day in the next 6 days, and would love to get this in the next release. |
|
Please fix CI issues |
|
@yonzhan It's unclear to me what is happening in the Test Extensions Loading Python311 job. Could you take a look? |
|
@dantedallag This issue has been fixed in |
dantedallag
force-pushed
the
enable-mg-scoped-deployments
branch
from
1774015 to
14d237c
Compare
|
@bebound @zhoxing-ms @yonzhan Issues have been addressed and all checks are passing. Please continue review. |
|
@zhoxing-ms @yonzhan @bebound - friendly ping on review here. Thanks! |
ReaNAiveD
approved these changes
Nov 6, 2023
zhoxing-ms
approved these changes
Nov 6, 2023
albertofori
pushed a commit
to albertofori/azure-cli
that referenced
this pull request
Dec 14, 2023
…ents for mg scoped stacks (Azure#27709)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az stack mg create
Description
MG scoped stacks used to always have the underlying deployment deployed to the default subscription scope (if another subscription is not supplied). We now want the underlying deployment to deploy to the default mg scope if no deployment subscription is provided.
There is also a change to the logic for handling a sub scoped stack with an underlying deployment scoped to a resource group. This was changed to match the first change, as they are the same case of a stack with a lower scoped underlying deployment.
Testing Guide
History Notes
[ARM] BREAKING CHANGE:
az stack mg create: Not supplying--deployment-scopewill no longer default the underlying deployment to the current subscription scope, but to the mg scope of the deployment stack.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.